[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Make it easier to figure out which test failed

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372915 )

Change subject: Make it easier to figure out which test failed
..


Make it easier to figure out which test failed

Setting a string key results in output like:
 MediaWikiStandardTest::testFile with data set
 "space_before_class_brace.php"

See 


Change-Id: Ia2094447b784945d5aa1195e4a541e124cf3f6ad
---
M MediaWiki/Tests/MediaWikiStandardTest.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Krinkle: Looks good to me, approved
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/MediaWiki/Tests/MediaWikiStandardTest.php 
b/MediaWiki/Tests/MediaWikiStandardTest.php
index 2ceb11e..4d0398f 100644
--- a/MediaWiki/Tests/MediaWikiStandardTest.php
+++ b/MediaWiki/Tests/MediaWikiStandardTest.php
@@ -65,7 +65,7 @@
if ( substr( $file, -4 ) !== '.php' ) {
continue;
}
-   $tests[] = [
+   $tests[$dir->getFilename()] = [
$file,
$standard,
"$file.expect"

-- 
To view, visit https://gerrit.wikimedia.org/r/372915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2094447b784945d5aa1195e4a541e124cf3f6ad
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Make it easier to figure out which test failed

[Legoktm (Code Review)]

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372915 )

Change subject: Make it easier to figure out which test failed
..

Make it easier to figure out which test failed

Setting a string key results in output like:
 MediaWikiStandardTest::testFile with data set
 "space_before_class_brace.php"

See 


Change-Id: Ia2094447b784945d5aa1195e4a541e124cf3f6ad
---
M MediaWiki/Tests/MediaWikiStandardTest.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer 
refs/changes/15/372915/1

diff --git a/MediaWiki/Tests/MediaWikiStandardTest.php 
b/MediaWiki/Tests/MediaWikiStandardTest.php
index 2ceb11e..4d0398f 100644
--- a/MediaWiki/Tests/MediaWikiStandardTest.php
+++ b/MediaWiki/Tests/MediaWikiStandardTest.php
@@ -65,7 +65,7 @@
if ( substr( $file, -4 ) !== '.php' ) {
continue;
}
-   $tests[] = [
+   $tests[$dir->getFilename()] = [
$file,
$standard,
"$file.expect"

-- 
To view, visit https://gerrit.wikimedia.org/r/372915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2094447b784945d5aa1195e4a541e124cf3f6ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits