[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: ApiRequest title normalisation: Use getPrefixedText from med...

2017-09-11 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/377401 )

Change subject: ApiRequest title normalisation: Use getPrefixedText from 
mediawiki-title
..


ApiRequest title normalisation: Use getPrefixedText from mediawiki-title

Update mediawiki-title to 0.6.4

Change-Id: I5ff530e241737df9442d4416438e759971adf27f
---
M lib/mw/ApiRequest.js
M package.json
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Looks good to me, approved



diff --git a/lib/mw/ApiRequest.js b/lib/mw/ApiRequest.js
index d8aab41..d540cad 100644
--- a/lib/mw/ApiRequest.js
+++ b/lib/mw/ApiRequest.js
@@ -191,8 +191,8 @@
if ( !titleObj ) {
return title;
}
-   // API wants spaces instead of underscores
-   return titleObj.getPrefixedDBKey().replace( /_/g, ' ' );
+   // API wants titles without underscores.
+   return titleObj.getPrefixedText();
 } );
 
 MWApiRequest.siteInfoCache = new Map();
diff --git a/package.json b/package.json
index 8ae0528..970f80f 100644
--- a/package.json
+++ b/package.json
@@ -27,7 +27,7 @@
 "js-yaml": "^3.6.1",
 "jsonwebtoken": "~5.6.0",
 "language-data": "git+https://github.com/wikimedia/language-data#master;,
-"mediawiki-title": "^0.6.3",
+"mediawiki-title": "^0.6.4",
 "preq": "^0.5.2",
 "sax": "1.2.1",
 "service-runner": "^2.2.5",

-- 
To view, visit https://gerrit.wikimedia.org/r/377401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ff530e241737df9442d4416438e759971adf27f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: Santhosh 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: ApiRequest title normalisation: Use getPrefixedText from med...

2017-09-11 Thread Santhosh (Code Review) 
Santhosh has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/377401 )

Change subject: ApiRequest title normalisation: Use getPrefixedText from 
mediawiki-title
..

ApiRequest title normalisation: Use getPrefixedText from mediawiki-title

Update mediawiki-title to 0.6.4

Change-Id: I5ff530e241737df9442d4416438e759971adf27f
---
M lib/mw/ApiRequest.js
M package.json
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/cxserver 
refs/changes/01/377401/1

diff --git a/lib/mw/ApiRequest.js b/lib/mw/ApiRequest.js
index d8aab41..d540cad 100644
--- a/lib/mw/ApiRequest.js
+++ b/lib/mw/ApiRequest.js
@@ -191,8 +191,8 @@
if ( !titleObj ) {
return title;
}
-   // API wants spaces instead of underscores
-   return titleObj.getPrefixedDBKey().replace( /_/g, ' ' );
+   // API wants titles without underscores.
+   return titleObj.getPrefixedText();
 } );
 
 MWApiRequest.siteInfoCache = new Map();
diff --git a/package.json b/package.json
index 8ae0528..970f80f 100644
--- a/package.json
+++ b/package.json
@@ -27,7 +27,7 @@
 "js-yaml": "^3.6.1",
 "jsonwebtoken": "~5.6.0",
 "language-data": "git+https://github.com/wikimedia/language-data#master;,
-"mediawiki-title": "^0.6.3",
+"mediawiki-title": "^0.6.4",
 "preq": "^0.5.2",
 "sax": "1.2.1",
 "service-runner": "^2.2.5",

-- 
To view, visit https://gerrit.wikimedia.org/r/377401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ff530e241737df9442d4416438e759971adf27f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: Santhosh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits