[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: test: Add test for Matxin MT

2017-11-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393520 )

Change subject: test: Add test for Matxin MT
..


test: Add test for Matxin MT

Change-Id: I87cb79e3889d8c6ec0220aa18b9e0bc1e9c63040
---
M lib/mt/Matxin.js
A test/mt/Matxin.test.js
2 files changed, 24 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Santhosh: Looks good to me, approved



diff --git a/lib/mt/Matxin.js b/lib/mt/Matxin.js
index c39e7dd..e8ade33 100644
--- a/lib/mt/Matxin.js
+++ b/lib/mt/Matxin.js
@@ -30,7 +30,8 @@
} ).then( ( response ) => response.body.translation.replace( 
/\. ॥ ॥\. /g, '.॥॥.' ) )
.catch( ( response ) => {
throw new Error( 'Translation with Matxin 
failed. Error: ' +
-   this.getErrorName( response.status ) + 
' ' + sourceLang + '-' + targetLang );
+   this.getErrorName( response.status ) +
+   ` for ${sourceLang} + > + 
${targetLang}` );
} );
}
 
diff --git a/test/mt/Matxin.test.js b/test/mt/Matxin.test.js
new file mode 100644
index 000..1c039b9
--- /dev/null
+++ b/test/mt/Matxin.test.js
@@ -0,0 +1,22 @@
+'use strict';
+
+const assert = require( '../utils/assert.js' );
+const server = require( '../utils/server.js' );
+const Matxin = require( '../../lib/mt' ).Matxin;
+
+describe( 'Matxin machine translation', function () {
+   it( 'Should fail because of wrong key ', () => {
+   const cxConfig = server.config.service;
+   cxConfig.conf.mt.Matxin.key = 'wrongkey';
+   const matxin = new Matxin( cxConfig );
+   const testSourceContent = 'Esta es una prueba';
+   assert.fails(
+   matxin.translate( 'es', 'eu', testSourceContent ),
+   function ( err ) {
+   if ( ( err instanceof Error ) && /value/.test( 
err ) ) {
+   return true;
+   }
+   }
+   );
+   } );
+} );

-- 
To view, visit https://gerrit.wikimedia.org/r/393520
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87cb79e3889d8c6ec0220aa18b9e0bc1e9c63040
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: KartikMistry 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: test: Add test for Matxin MT

2017-11-26 Thread KartikMistry (Code Review) 
KartikMistry has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393520 )

Change subject: test: Add test for Matxin MT
..

test: Add test for Matxin MT

Change-Id: I87cb79e3889d8c6ec0220aa18b9e0bc1e9c63040
---
M lib/mt/Matxin.js
A test/mt/Matxin.test.js
2 files changed, 24 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/cxserver 
refs/changes/20/393520/1

diff --git a/lib/mt/Matxin.js b/lib/mt/Matxin.js
index c39e7dd..e8ade33 100644
--- a/lib/mt/Matxin.js
+++ b/lib/mt/Matxin.js
@@ -30,7 +30,8 @@
} ).then( ( response ) => response.body.translation.replace( 
/\. ॥ ॥\. /g, '.॥॥.' ) )
.catch( ( response ) => {
throw new Error( 'Translation with Matxin 
failed. Error: ' +
-   this.getErrorName( response.status ) + 
' ' + sourceLang + '-' + targetLang );
+   this.getErrorName( response.status ) +
+   ` for ${sourceLang} + > + 
${targetLang}` );
} );
}
 
diff --git a/test/mt/Matxin.test.js b/test/mt/Matxin.test.js
new file mode 100644
index 000..1c039b9
--- /dev/null
+++ b/test/mt/Matxin.test.js
@@ -0,0 +1,22 @@
+'use strict';
+
+const assert = require( '../utils/assert.js' );
+const server = require( '../utils/server.js' );
+const Matxin = require( '../../lib/mt' ).Matxin;
+
+describe( 'Matxin machine translation', function () {
+   it( 'Should fail because of wrong key ', () => {
+   const cxConfig = server.config.service;
+   cxConfig.conf.mt.Matxin.key = 'wrongkey';
+   const matxin = new Matxin( cxConfig );
+   const testSourceContent = 'Esta es una prueba';
+   assert.fails(
+   matxin.translate( 'es', 'eu', testSourceContent ),
+   function ( err ) {
+   if ( ( err instanceof Error ) && /value/.test( 
err ) ) {
+   return true;
+   }
+   }
+   );
+   } );
+} );

-- 
To view, visit https://gerrit.wikimedia.org/r/393520
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I87cb79e3889d8c6ec0220aa18b9e0bc1e9c63040
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: KartikMistry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits