[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: Refactor sectioning tests

2017-09-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/377347 )

Change subject: Hygiene: Refactor sectioning tests
..


Hygiene: Refactor sectioning tests

Change-Id: I2c818450432681318f546dc37cbc09db0c47817e
---
M test/lib/parsoid/parsoid-sections-test.js
1 file changed, 6 insertions(+), 8 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/test/lib/parsoid/parsoid-sections-test.js 
b/test/lib/parsoid/parsoid-sections-test.js
index 9ec100d..bf1a655 100644
--- a/test/lib/parsoid/parsoid-sections-test.js
+++ b/test/lib/parsoid/parsoid-sections-test.js
@@ -4,11 +4,6 @@
 const domino = require('domino');
 const parsoid = require('../../../lib/parsoidSections');
 
-const html = 'text0' +
-'footext1' +
-'Funny section !@#$%^&*()text2' +
-'';
-
 describe('lib:parsoid-sections', function() {
 
 this.timeout(2); // eslint-disable-line no-invalid-this
@@ -18,12 +13,12 @@
 assert.deepEqual(sections[0].text, 'text0', 
JSON.stringify(sections[0], null, 2));
 }
 
-function assertSection1(sections) {
+function assertSection1(sections, extraText = '') {
 assert.deepEqual(sections[1].id, 1);
 assert.deepEqual(sections[1].toclevel, 1);
 assert.deepEqual(sections[1].line, 'foo');
 assert.deepEqual(sections[1].anchor, 'foo');
-assert.deepEqual(sections[1].text, 'text1');
+assert.deepEqual(sections[1].text, `text1${extraText}`);
 }
 
 function assertSection2(sections) {
@@ -62,7 +57,10 @@
 });
 
 it('getSectionsText() with one h2 and h3 should produce three sections', 
() => {
-const doc = domino.createDocument(html);
+const doc = domino.createDocument('text0' +
+'footext1' +
+'Funny section 
!@#$%^&*()text2' +
+'');
 parsoid.addSectionDivs(doc);
 const sections = parsoid.getSectionsText(doc);
 assert.deepEqual(sections.length, 3);

-- 
To view, visit https://gerrit.wikimedia.org/r/377347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2c818450432681318f546dc37cbc09db0c47817e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: Refactor sectioning tests

2017-09-11 Thread BearND (Code Review) 
BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/377347 )

Change subject: Hygiene: Refactor sectioning tests
..

Hygiene: Refactor sectioning tests

Change-Id: I2c818450432681318f546dc37cbc09db0c47817e
---
M test/lib/parsoid/parsoid-sections-test.js
1 file changed, 6 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/47/377347/1

diff --git a/test/lib/parsoid/parsoid-sections-test.js 
b/test/lib/parsoid/parsoid-sections-test.js
index 9ec100d..bf1a655 100644
--- a/test/lib/parsoid/parsoid-sections-test.js
+++ b/test/lib/parsoid/parsoid-sections-test.js
@@ -4,11 +4,6 @@
 const domino = require('domino');
 const parsoid = require('../../../lib/parsoidSections');
 
-const html = 'text0' +
-'footext1' +
-'Funny section !@#$%^&*()text2' +
-'';
-
 describe('lib:parsoid-sections', function() {
 
 this.timeout(2); // eslint-disable-line no-invalid-this
@@ -18,12 +13,12 @@
 assert.deepEqual(sections[0].text, 'text0', 
JSON.stringify(sections[0], null, 2));
 }
 
-function assertSection1(sections) {
+function assertSection1(sections, extraText = '') {
 assert.deepEqual(sections[1].id, 1);
 assert.deepEqual(sections[1].toclevel, 1);
 assert.deepEqual(sections[1].line, 'foo');
 assert.deepEqual(sections[1].anchor, 'foo');
-assert.deepEqual(sections[1].text, 'text1');
+assert.deepEqual(sections[1].text, `text1${extraText}`);
 }
 
 function assertSection2(sections) {
@@ -62,7 +57,10 @@
 });
 
 it('getSectionsText() with one h2 and h3 should produce three sections', 
() => {
-const doc = domino.createDocument(html);
+const doc = domino.createDocument('text0' +
+'footext1' +
+'Funny section 
!@#$%^&*()text2' +
+'');
 parsoid.addSectionDivs(doc);
 const sections = parsoid.getSectionsText(doc);
 assert.deepEqual(sections.length, 3);

-- 
To view, visit https://gerrit.wikimedia.org/r/377347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c818450432681318f546dc37cbc09db0c47817e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits