[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for unit te...

2018-01-17 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404742 )

Change subject: Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for unit test 
run
..


Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for unit test run

Our unit tests are not supposed to use the internet anyways.

Change-Id: I3208ca378e48fa64450cd5fad3678e608f6fcd32
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/package.json b/package.json
index adb9e56..91b5d2b 100644
--- a/package.json
+++ b/package.json
@@ -6,7 +6,7 @@
   "scripts": {
 "start": "service-runner",
 "test": "PREQ_CONNECT_TIMEOUT=15 mocha && nsp check",
-"test:unit": "PREQ_CONNECT_TIMEOUT=15 mocha test/lib",
+"test:unit": "mocha test/lib",
 "lint": "eslint --cache --max-warnings 0 --ext .js --ext .json .",
 "docker-start": "service-runner docker-start",
 "docker-test": "service-runner docker-test",

-- 
To view, visit https://gerrit.wikimedia.org/r/404742
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3208ca378e48fa64450cd5fad3678e608f6fcd32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for unit te...

2018-01-17 Thread BearND (Code Review) 
BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404742 )

Change subject: Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for unit test 
run
..

Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for unit test run

Our unit tests are not supposed to use the internet anyways.

Change-Id: I3208ca378e48fa64450cd5fad3678e608f6fcd32
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/42/404742/1

diff --git a/package.json b/package.json
index adb9e56..91b5d2b 100644
--- a/package.json
+++ b/package.json
@@ -6,7 +6,7 @@
   "scripts": {
 "start": "service-runner",
 "test": "PREQ_CONNECT_TIMEOUT=15 mocha && nsp check",
-"test:unit": "PREQ_CONNECT_TIMEOUT=15 mocha test/lib",
+"test:unit": "mocha test/lib",
 "lint": "eslint --cache --max-warnings 0 --ext .js --ext .json .",
 "docker-start": "service-runner docker-start",
 "docker-test": "service-runner docker-test",

-- 
To view, visit https://gerrit.wikimedia.org/r/404742
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3208ca378e48fa64450cd5fad3678e608f6fcd32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits