[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix swagger-ui spec parsing

2017-11-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/391075 )

Change subject: Fix swagger-ui spec parsing
..


Fix swagger-ui spec parsing

This was failing due to the types of items in arrays not being
specified.

Bug: T174983
Change-Id: I2a9b4034f46993d070dacd6633c32a56a4951e44
---
M spec.yaml
1 file changed, 14 insertions(+), 2 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/spec.yaml b/spec.yaml
index 839822c..484eea4 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -840,6 +840,8 @@
   $merge:
 type: array
 description: One-element array containing the link to the RESTBase 
summary for the article
+items:
+  type: string
 required:
   - $merge
 
@@ -975,6 +977,8 @@
   $merge:
 type: array
 description: One-element array containing the link to the RESTBase 
summary for the article
+items:
+  type: string
   views:
 type: integer
 description: Number of views on the requested day
@@ -1137,7 +1141,8 @@
   platforms:
 type: array
 description: An array of platforms to display the announcement. 
Possible values are "iOSApp" or "AndroidApp"
-items: { type: string }
+items:
+  type: string
   text:
 type: string
 description: The text of the announcement
@@ -1158,7 +1163,8 @@
   countries:
 type: array
 description: An array of country codes in which to display the 
announcement. Clients should derive the country from 'GeoIP' portion of the 
Set-Cookie header
-items: { type: string }
+items:
+  type: string
 required:
   - id
   - type
@@ -1191,6 +1197,8 @@
   lang:
 type: array
 description: A list of wiki language codes documenting the language(s) 
of the articles in the compilation
+items:
+  type: string
   summary:
 type: string
 description: A short description of the compilation contents
@@ -1264,6 +1272,8 @@
   derivatives:
 type: array
 description: a list of derivatives of the original file (applies only 
to videos)
+items:
+  type: object
   ext:
 type: object
 description: extended metadata about the object (provided by the 
CommonsMetadata extension)
@@ -1300,6 +1310,8 @@
   data:
 type: array
 description: Buffer contents
+items:
+  type: string
 additionalProperties: false
 
   titles_set:

-- 
To view, visit https://gerrit.wikimedia.org/r/391075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a9b4034f46993d070dacd6633c32a56a4951e44
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix swagger-ui spec parsing

2017-11-13 Thread Mholloway (Code Review) 
Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391075 )

Change subject: Fix swagger-ui spec parsing
..

Fix swagger-ui spec parsing

This was failing due to the types of items in arrays not being
specified.

Bug: T174983
Change-Id: I2a9b4034f46993d070dacd6633c32a56a4951e44
---
M spec.yaml
1 file changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/75/391075/1

diff --git a/spec.yaml b/spec.yaml
index e12008f..05dca89 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -833,6 +833,8 @@
   $merge:
 type: array
 description: One-element array containing the link to the RESTBase 
summary for the article
+items:
+  type: string
 required:
   - $merge
 
@@ -960,6 +962,8 @@
   $merge:
 type: array
 description: One-element array containing the link to the RESTBase 
summary for the article
+items:
+  type: string
   views:
 type: integer
 description: Number of views on the requested day
@@ -1122,7 +1126,8 @@
   platforms:
 type: array
 description: An array of platforms to display the announcement. 
Possible values are "iOSApp" or "AndroidApp"
-items: { type: string }
+items:
+  type: string
   text:
 type: string
 description: The text of the announcement
@@ -1143,7 +1148,8 @@
   countries:
 type: array
 description: An array of country codes in which to display the 
announcement. Clients should derive the country from 'GeoIP' portion of the 
Set-Cookie header
-items: { type: string }
+items:
+  type: string
 required:
   - id
   - type
@@ -1176,6 +1182,8 @@
   lang:
 type: array
 description: A list of wiki language codes documenting the language(s) 
of the articles in the compilation
+items:
+  type: string
   summary:
 type: string
 description: A short description of the compilation contents
@@ -1249,6 +1257,8 @@
   derivatives:
 type: array
 description: a list of derivatives of the original file (applies only 
to videos)
+items:
+  type: object
   ext:
 type: object
 description: extended metadata about the object (provided by the 
CommonsMetadata extension)
@@ -1285,6 +1295,8 @@
   data:
 type: array
 description: Buffer contents
+items:
+  type: string
 additionalProperties: false
 
   titles_set:

-- 
To view, visit https://gerrit.wikimedia.org/r/391075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a9b4034f46993d070dacd6633c32a56a4951e44
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits