jenkins-bot has submitted this change and it was merged.
Change subject: Remove jscs in preparation for node template update
..
Remove jscs in preparation for node template update
The new node template update enforces code styling conventions
with eslint. When that happens we no longer need to rely
on jscs for code styling.
Change-Id: I1df9549668dc1056c8affdbbc976d58f6dc40fbb
---
D .jscsrc
D Gruntfile.js
M package.json
3 files changed, 1 insertion(+), 58 deletions(-)
Approvals:
Mholloway: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.jscsrc b/.jscsrc
deleted file mode 100644
index 27a0ed2..000
--- a/.jscsrc
+++ /dev/null
@@ -1,36 +0,0 @@
-{
- "preset": "wikimedia",
-
- "requireSpaceAfterLineComment": null,
- "requireSpacesInsideParentheses": false,
- "requireSpacesInsideBrackets": false,
- "requireSpaceAfterKeywords": false,
- "requireMultipleVarDecl": null,
- "requireLineBreakAfterVariableAssignment": null,
- "requireSpaceAfterBinaryOperators": null,
- "validateQuoteMarks": null,
- "disallowTrailingComma": null,
- "disallowQuotedKeysInObjects": null,
- "requireSpaceBeforeObjectValues": null,
- "disallowDanglingUnderscores": null,
- "disallowImplicitTypeConversion": null,
- "requireCamelCaseOrUpperCaseIdentifiers": null,
- "disallowSpaceAfterObjectKeys": null,
- "requireSpaceBeforeBinaryOperators": null,
- "disallowMultipleLineBreaks": null,
- "requireDotNotation": null,
- "disallowSpacesInsideParentheses": null,
- "validateIndentation": 4,
- "requireSpaceBeforeKeywords": null,
- "disallowMixedSpacesAndTabs": null,
- "requireLineFeedAtFileEnd": null,
- "requireSpacesInsideObjectBrackets": null,
- "requireSpaceBetweenArguments": null,
- "disallowUnusedVariables": true,
- "disallowVar": true,
- "requireVarDeclFirst": null,
- "jsDoc": null,
- "excludeFiles": [
-"node_modules/**"
- ]
-}
diff --git a/Gruntfile.js b/Gruntfile.js
deleted file mode 100644
index 7f369b8..000
--- a/Gruntfile.js
+++ /dev/null
@@ -1,19 +0,0 @@
-"use strict";
-
-module.exports = function ( grunt ) {
- grunt.loadNpmTasks("grunt-jscs");
-
- grunt.initConfig( {
-jscs: {
-src: ['lib/**/*.js', 'routes/*.js', 'test/**/*.js' ],
-options: {
-config: ".jscsrc",
-requireCurlyBraces: [ "if" ]
-}
-}
- } );
-
- grunt.registerTask( 'test', [ 'jscs' ] );
-
- grunt.registerTask( 'default', [ 'test' ] );
-};
diff --git a/package.json b/package.json
index 8b84803..4b30e76 100644
--- a/package.json
+++ b/package.json
@@ -5,7 +5,7 @@
"main": "./app.js",
"scripts": {
"start": "service-runner",
-"test": "grunt test && mocha && nsp check",
+"test": "mocha && nsp check",
"docker-start": "service-runner docker-start",
"docker-test": "service-runner docker-test",
"coverage": "istanbul cover _mocha -- -R spec"
@@ -59,8 +59,6 @@
"ajv": "^4.7.7",
"csv-parse": "^1.1.7",
"extend": "^3.0.0",
-"grunt": "^1.0.1",
-"grunt-jscs": "^3.0.1",
"istanbul": "^0.4.5",
"mocha": "^3.1.2",
"mocha-jshint": "^2.3.1",
--
To view, visit https://gerrit.wikimedia.org/r/324266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1df9549668dc1056c8affdbbc976d58f6dc40fbb
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson
Gerrit-Reviewer: BearND
Gerrit-Reviewer: Dbrant
Gerrit-Reviewer: Fjalapeno
Gerrit-Reviewer: GWicke
Gerrit-Reviewer: Jdlrobson
Gerrit-Reviewer: Jhernandez
Gerrit-Reviewer: Mholloway
Gerrit-Reviewer: Mhurd
Gerrit-Reviewer: Mobrovac
Gerrit-Reviewer: Niedzielski
Gerrit-Reviewer: Ppchelko
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
