[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Revert "Stop getting dc:lastmodified"

2018-01-08 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/402837 )

Change subject: Revert "Stop getting dc:lastmodified"
..


Revert "Stop getting dc:lastmodified"

Needed for making the summary 'timestamp' field refer to the correct
revision.

This reverts commit bf67c970253ca701fde856330e0347581cd57063.

Bug: T184429
Change-Id: Ibbc20436c0a0cb6d5301c54ba399024d73a53a77
---
M lib/parsoid-access.js
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/parsoid-access.js b/lib/parsoid-access.js
index 3ae3308..8633db3 100644
--- a/lib/parsoid-access.js
+++ b/lib/parsoid-access.js
@@ -72,6 +72,15 @@
 }
 
 /**
+ * 
+ * @param {!document} doc
+ */
+function getModified(doc) {
+return doc.querySelector('head > 
meta[property="dc:modified"]').getAttribute('content')
+.replace(/\.000Z$/, 'Z');
+}
+
+/**
  * Gets the base URI from a Parsoid document
  * 
  * @param {!document} doc
@@ -109,6 +118,7 @@
 const doc = domino.createDocument(response.body);
 
 // Note: these properties must be obtained before stripping markup
+page.lastmodified = getModified(doc);
 parseProperty.parsePronunciation(doc, page);
 parseProperty.parseSpokenWikipedia(doc, page);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/402837
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbc20436c0a0cb6d5301c54ba399024d73a53a77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Revert "Stop getting dc:lastmodified"

2018-01-08 Thread Mholloway (Code Review) 
Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402837 )

Change subject: Revert "Stop getting dc:lastmodified"
..

Revert "Stop getting dc:lastmodified"

Needed for making the summary 'timestamp' field refer to the correct
revision.

This reverts commit bf67c970253ca701fde856330e0347581cd57063.

Bug: T184429
Change-Id: Ibbc20436c0a0cb6d5301c54ba399024d73a53a77
---
M lib/parsoid-access.js
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/37/402837/1

diff --git a/lib/parsoid-access.js b/lib/parsoid-access.js
index 3ae3308..8633db3 100644
--- a/lib/parsoid-access.js
+++ b/lib/parsoid-access.js
@@ -72,6 +72,15 @@
 }
 
 /**
+ * 
+ * @param {!document} doc
+ */
+function getModified(doc) {
+return doc.querySelector('head > 
meta[property="dc:modified"]').getAttribute('content')
+.replace(/\.000Z$/, 'Z');
+}
+
+/**
  * Gets the base URI from a Parsoid document
  * 
  * @param {!document} doc
@@ -109,6 +118,7 @@
 const doc = domino.createDocument(response.body);
 
 // Note: these properties must be obtained before stripping markup
+page.lastmodified = getModified(doc);
 parseProperty.parsePronunciation(doc, page);
 parseProperty.parseSpokenWikipedia(doc, page);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/402837
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbc20436c0a0cb6d5301c54ba399024d73a53a77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits