[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Suppress logspam in production logs
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/379670 )
Change subject: Suppress logspam in production logs
..
Suppress logspam in production logs
* We have known about these for a long time and we've whacked
moles over time, but this is the best we are doing for now
till we do another round of investigation going over parser tests.
* Production is configured for log message level warn and above.
Change-Id: I7d3c870a8852c4419f4501b5c26f0e40699bd28b
---
M lib/html2wt/separators.js
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Arlolra: Looks good to me, approved
diff --git a/lib/html2wt/separators.js b/lib/html2wt/separators.js
index 1a617d8..2c72f2e 100644
--- a/lib/html2wt/separators.js
+++ b/lib/html2wt/separators.js
@@ -90,7 +90,7 @@
if (b.min !== undefined) {
if (nlConstraints.max !== undefined &&
nlConstraints.max < b.min) {
// Conflict, warn and let nodeB win.
- env.log("warn", "Incompatible constraints 1:",
nodeA.nodeName,
+ env.log("info/html2wt", "Incompatible
constraints 1:", nodeA.nodeName,
nodeB.nodeName,
loggableConstraints(nlConstraints));
nlConstraints.min = b.min;
nlConstraints.max = b.min;
@@ -102,7 +102,7 @@
if (b.max !== undefined) {
if (nlConstraints.min !== undefined &&
nlConstraints.min > b.max) {
// Conflict, warn and let nodeB win.
- env.log("warn", "Incompatible constraints 2:",
nodeA.nodeName,
+ env.log("info/html2wt", "Incompatible
constraints 2:", nodeA.nodeName,
nodeB.nodeName,
loggableConstraints(nlConstraints));
nlConstraints.min = b.max;
nlConstraints.max = b.max;
@@ -278,7 +278,7 @@
}
res.max = res.min;
- env.log("warn", 'Incompatible constraints (merge):', res,
+ env.log("info/html2wt", 'Incompatible constraints (merge):',
res,
loggableConstraints(oldConstraints),
loggableConstraints(newConstraints));
}
return res;
@@ -629,7 +629,7 @@
sep = src.substring(dsrA[1], dsrB[1] -
dsrB[3]);
}
} else {
- this.env.log("warn", "dsr backwards: should not
happen!");
+ this.env.log("info/html2wt", "dsr backwards:
should not happen!");
}
if (state.sep.lastSourceSep) {
--
To view, visit https://gerrit.wikimedia.org/r/379670
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d3c870a8852c4419f4501b5c26f0e40699bd28b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry
Gerrit-Reviewer: Arlolra
Gerrit-Reviewer: C. Scott Ananian
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Suppress logspam in production logs
Subramanya Sastry has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379670 )
Change subject: Suppress logspam in production logs
..
Suppress logspam in production logs
* We have known about these for a long time and we've whacked
moles over time, but this is the best we are doing for now
till we do another round of investigation going over parser tests.
* Production is configured for log message level warn and above.
Change-Id: I7d3c870a8852c4419f4501b5c26f0e40699bd28b
---
M lib/html2wt/separators.js
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/70/379670/1
diff --git a/lib/html2wt/separators.js b/lib/html2wt/separators.js
index 1a617d8..2c72f2e 100644
--- a/lib/html2wt/separators.js
+++ b/lib/html2wt/separators.js
@@ -90,7 +90,7 @@
if (b.min !== undefined) {
if (nlConstraints.max !== undefined &&
nlConstraints.max < b.min) {
// Conflict, warn and let nodeB win.
- env.log("warn", "Incompatible constraints 1:",
nodeA.nodeName,
+ env.log("info/html2wt", "Incompatible
constraints 1:", nodeA.nodeName,
nodeB.nodeName,
loggableConstraints(nlConstraints));
nlConstraints.min = b.min;
nlConstraints.max = b.min;
@@ -102,7 +102,7 @@
if (b.max !== undefined) {
if (nlConstraints.min !== undefined &&
nlConstraints.min > b.max) {
// Conflict, warn and let nodeB win.
- env.log("warn", "Incompatible constraints 2:",
nodeA.nodeName,
+ env.log("info/html2wt", "Incompatible
constraints 2:", nodeA.nodeName,
nodeB.nodeName,
loggableConstraints(nlConstraints));
nlConstraints.min = b.max;
nlConstraints.max = b.max;
@@ -278,7 +278,7 @@
}
res.max = res.min;
- env.log("warn", 'Incompatible constraints (merge):', res,
+ env.log("info/html2wt", 'Incompatible constraints (merge):',
res,
loggableConstraints(oldConstraints),
loggableConstraints(newConstraints));
}
return res;
@@ -629,7 +629,7 @@
sep = src.substring(dsrA[1], dsrB[1] -
dsrB[3]);
}
} else {
- this.env.log("warn", "dsr backwards: should not
happen!");
+ this.env.log("info/html2wt", "dsr backwards:
should not happen!");
}
if (state.sep.lastSourceSep) {
--
To view, visit https://gerrit.wikimedia.org/r/379670
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d3c870a8852c4419f4501b5c26f0e40699bd28b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
