[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: linter: Log API failures to env.log

2016-10-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: linter: Log API failures to env.log
..


linter: Log API failures to env.log

Change-Id: I24339bd2bf227e80a545cfa1aa0d9e7215e80513
---
M lib/logger/linter.js
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Arlolra: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/logger/linter.js b/lib/logger/linter.js
index 210e463..b446ff1 100644
--- a/lib/logger/linter.js
+++ b/lib/logger/linter.js
@@ -48,13 +48,15 @@
formatversion: 2,
}, },
function(error, response, body) {
-   console.log(body);
+   if (response.statusCode !== 
200) {
+   
env.log('error/lint-api', body);
+   }
}
);
}
}
} catch (e) {
-   console.error("Error in logLintOutput: " + e);
+   env.log('error/lint-api', "Error in logLintOutput: " + e);
} finally {
cb();
}
@@ -99,8 +101,7 @@
this.buffer.push(msg);
 
} catch (e) {
-   console.error("Error in linterBackend: " + e);
-   return;
+   this._env.log("error/linter", "Error in linterBackend: " + e);
} finally {
cb();
}

-- 
To view, visit https://gerrit.wikimedia.org/r/316214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24339bd2bf227e80a545cfa1aa0d9e7215e80513
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Arlolra 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: linter: Log API failures to env.log

2016-10-15 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316214

Change subject: linter: Log API failures to env.log
..

linter: Log API failures to env.log

Change-Id: I24339bd2bf227e80a545cfa1aa0d9e7215e80513
---
M lib/logger/linter.js
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/14/316214/1

diff --git a/lib/logger/linter.js b/lib/logger/linter.js
index 210e463..32d97bc 100644
--- a/lib/logger/linter.js
+++ b/lib/logger/linter.js
@@ -48,7 +48,12 @@
formatversion: 2,
}, },
function(error, response, body) {
-   console.log(body);
+   if (response.statusCode !== 200 
) {
+   
env.log('error/lint-api', body);
+   } else {
+   // For debug
+   console.log(body);
+   }
}
);
}

-- 
To view, visit https://gerrit.wikimedia.org/r/316214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I24339bd2bf227e80a545cfa1aa0d9e7215e80513
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits