[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Define npm peer dependency explicitly

2017-08-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/368640 )

Change subject: Define npm peer dependency explicitly
..


Define npm peer dependency explicitly

npm 3 requires dependencies to be explicitly defined.

Bug: T172094
Change-Id: Ic640ccf0f577e47036d473892522ea758014fab4
---
M package.json
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  BearND: Looks good to me, but someone else must approve
  Hashar: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Jdlrobson: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index 6a5b000..a46160a 100644
--- a/package.json
+++ b/package.json
@@ -39,6 +39,7 @@
   "devDependencies": {
 "extend": "^3.0.0",
 "istanbul": "^0.4.4",
+"jscs": "^3.0.3",
 "mocha": "^2.5.3",
 "mocha-jscs": "^5.0.1",
 "mocha-jshint": "^2.3.1",

-- 
To view, visit https://gerrit.wikimedia.org/r/368640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic640ccf0f577e47036d473892522ea758014fab4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Define npm peer dependency explicitly

2017-07-31 Thread Hashar (Code Review) 
Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368640 )

Change subject: Define npm peer dependency explicitly
..

Define npm peer dependency explicitly

npm 3 requires dependencies to be explicitly defined.

Bug: T172094
Change-Id: Ic640ccf0f577e47036d473892522ea758014fab4
---
M package.json
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/trending-edits 
refs/changes/40/368640/1

diff --git a/package.json b/package.json
index 6a5b000..a46160a 100644
--- a/package.json
+++ b/package.json
@@ -39,6 +39,7 @@
   "devDependencies": {
 "extend": "^3.0.0",
 "istanbul": "^0.4.4",
+"jscs": "^3.0.3",
 "mocha": "^2.5.3",
 "mocha-jscs": "^5.0.1",
 "mocha-jshint": "^2.3.1",

-- 
To view, visit https://gerrit.wikimedia.org/r/368640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic640ccf0f577e47036d473892522ea758014fab4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits