[MediaWiki-commits] [Gerrit] mediawiki...webplatform[master]: Convert to short array syntax
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392010 ) Change subject: Convert to short array syntax .. Convert to short array syntax Also fixed the documentation for WebPlatformTemplate::renderSearch(). Change-Id: I4e4ef728e9bf45d0d32e2565b5e8729160533b30 --- M WebPlatformTemplate.class.php 1 file changed, 7 insertions(+), 10 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/WebPlatformTemplate.class.php b/WebPlatformTemplate.class.php index f96ea77..7a9148f 100644 --- a/WebPlatformTemplate.class.php +++ b/WebPlatformTemplate.class.php @@ -109,7 +109,7 @@ http://webplatform.org/";>HOME DOCS - + @@ -121,7 +121,7 @@ - + data['sitenotice'] ): ?> @@ -319,11 +319,11 @@ $link = $this->data['view_urls']['form_edit']; } } else { - $link = array( + $link = [ 'href' => Skin::makeSpecialUrl( 'Userlogin' ), 'id' => 'ca-edit', 'text' => $this->getSkin()->msg( 'edit' )->text() - ); + ]; } ?> @@ -422,10 +422,7 @@ } /** -* Render one or more navigations elements by name, automatically reveresed -* when UI is in RTL mode -* -* @param $elements array +* Render the search portlet */ private function renderSearch() { ?> @@ -438,8 +435,8 @@ makeSearchInput( array( 'id' => 'searchInput', 'type' => 'input' ) ); - echo $this->makeSearchButton( 'fulltext', array( 'id' => 'mw-searchButton', 'class' => 'searchButton', 'value' => ' ' ) ); + echo $this->makeSearchInput( [ 'id' => 'searchInput', 'type' => 'input' ] ); + echo $this->makeSearchButton( 'fulltext', [ 'id' => 'mw-searchButton', 'class' => 'searchButton', 'value' => ' ' ] ); ?> -- To view, visit https://gerrit.wikimedia.org/r/392010 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e4ef728e9bf45d0d32e2565b5e8729160533b30 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/webplatform Gerrit-Branch: master Gerrit-Owner: Jack Phoenix Gerrit-Reviewer: Legoktm Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...webplatform[master]: Convert to short array syntax
Jack Phoenix has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392010 ) Change subject: Convert to short array syntax .. Convert to short array syntax Also fixed the documentation for WebPlatformTemplate::renderSearch(). Change-Id: I4e4ef728e9bf45d0d32e2565b5e8729160533b30 --- M WebPlatformTemplate.class.php 1 file changed, 7 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/webplatform refs/changes/10/392010/1 diff --git a/WebPlatformTemplate.class.php b/WebPlatformTemplate.class.php index f96ea77..7a9148f 100644 --- a/WebPlatformTemplate.class.php +++ b/WebPlatformTemplate.class.php @@ -109,7 +109,7 @@ http://webplatform.org/";>HOME DOCS - + @@ -121,7 +121,7 @@ - + data['sitenotice'] ): ?> @@ -319,11 +319,11 @@ $link = $this->data['view_urls']['form_edit']; } } else { - $link = array( + $link = [ 'href' => Skin::makeSpecialUrl( 'Userlogin' ), 'id' => 'ca-edit', 'text' => $this->getSkin()->msg( 'edit' )->text() - ); + ]; } ?> @@ -422,10 +422,7 @@ } /** -* Render one or more navigations elements by name, automatically reveresed -* when UI is in RTL mode -* -* @param $elements array +* Render the search portlet */ private function renderSearch() { ?> @@ -438,8 +435,8 @@ makeSearchInput( array( 'id' => 'searchInput', 'type' => 'input' ) ); - echo $this->makeSearchButton( 'fulltext', array( 'id' => 'mw-searchButton', 'class' => 'searchButton', 'value' => ' ' ) ); + echo $this->makeSearchInput( [ 'id' => 'searchInput', 'type' => 'input' ] ); + echo $this->makeSearchButton( 'fulltext', [ 'id' => 'mw-searchButton', 'class' => 'searchButton', 'value' => ' ' ] ); ?> -- To view, visit https://gerrit.wikimedia.org/r/392010 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4e4ef728e9bf45d0d32e2565b5e8729160533b30 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/webplatform Gerrit-Branch: master Gerrit-Owner: Jack Phoenix ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits