[MediaWiki-commits] [Gerrit] mediawiki.util: Add JS-handler usage example for addPortletL... - change (mediawiki/core)

2016-01-22 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/265834

Change subject: mediawiki.util: Add JS-handler usage example for 
addPortletLink()
..

mediawiki.util: Add JS-handler usage example for addPortletLink()

Makes it clear that the method returns the Element node which
can then be used to attach event handlers.

Change-Id: Id33d3dc24a439cc6fe86f2de5baafa0aa779b2c0
---
M resources/src/mediawiki/mediawiki.util.js
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/34/265834/1

diff --git a/resources/src/mediawiki/mediawiki.util.js 
b/resources/src/mediawiki/mediawiki.util.js
index f9810f9..1cb4d66 100644
--- a/resources/src/mediawiki/mediawiki.util.js
+++ b/resources/src/mediawiki/mediawiki.util.js
@@ -235,10 +235,20 @@
 * (e.g. `'#foobar'`) for that item.
 *
 * mw.util.addPortletLink(
-* 'p-tb', 'http://mediawiki.org/',
-* 'MediaWiki.org', 't-mworg', 'Go to MediaWiki.org ', 
'm', '#t-print'
+* 'p-tb', 'https://www.mediawiki.org/',
+* 'mediawiki.org', 't-mworg', 'Go to mediawiki.org', 
'm', '#t-print'
 * );
 *
+* var node = mw.util.addPortletLink(
+* 'p-tb',
+* new mw.Title( 'Special:ExamplePanel' ).getUrl(),
+* 'Panel'
+* );
+* $( node ).on( 'click', function ( e ) {
+* mw.example.Panel.create().show();
+* e.preventDefault();
+* } );
+*
 * @param {string} portlet ID of the target portlet ( 
'p-cactions' or 'p-personal' etc.)
 * @param {string} href Link URL
 * @param {string} text Link text

-- 
To view, visit https://gerrit.wikimedia.org/r/265834
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id33d3dc24a439cc6fe86f2de5baafa0aa779b2c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki.util: Add JS-handler usage example for addPortletL... - change (mediawiki/core)

2016-01-22 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: mediawiki.util: Add JS-handler usage example for 
addPortletLink()
..


mediawiki.util: Add JS-handler usage example for addPortletLink()

Makes it clear that the method returns the Element node which
can then be used to attach event handlers.

Change-Id: Id33d3dc24a439cc6fe86f2de5baafa0aa779b2c0
---
M resources/src/mediawiki/mediawiki.util.js
1 file changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/src/mediawiki/mediawiki.util.js 
b/resources/src/mediawiki/mediawiki.util.js
index f9810f9..cc983e4 100644
--- a/resources/src/mediawiki/mediawiki.util.js
+++ b/resources/src/mediawiki/mediawiki.util.js
@@ -235,10 +235,20 @@
 * (e.g. `'#foobar'`) for that item.
 *
 * mw.util.addPortletLink(
-* 'p-tb', 'http://mediawiki.org/',
-* 'MediaWiki.org', 't-mworg', 'Go to MediaWiki.org ', 
'm', '#t-print'
+* 'p-tb', 'https://www.mediawiki.org/',
+* 'mediawiki.org', 't-mworg', 'Go to mediawiki.org', 
'm', '#t-print'
 * );
 *
+* var node = mw.util.addPortletLink(
+* 'p-tb',
+* new mw.Title( 'Special:Example' ).getUrl(),
+* 'Example'
+* );
+* $( node ).on( 'click', function ( e ) {
+* console.log( 'Example' );
+* e.preventDefault();
+* } );
+*
 * @param {string} portlet ID of the target portlet ( 
'p-cactions' or 'p-personal' etc.)
 * @param {string} href Link URL
 * @param {string} text Link text

-- 
To view, visit https://gerrit.wikimedia.org/r/265834
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id33d3dc24a439cc6fe86f2de5baafa0aa779b2c0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Edokter 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits