[MediaWiki-commits] [Gerrit] mediawiki.widgets.CategorySelector: Add missing dependency f... - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: mediawiki.widgets.CategorySelector: Add missing dependency for 
ForeignApi and Title
..


mediawiki.widgets.CategorySelector: Add missing dependency for ForeignApi and 
Title

Follows-up e6d1550309 which attempted to backport 86dedeea7f but
left out the dependencies.

Fixes fatal error in REL1_26 qunit tests:
> Exception in module-execute in module mediawiki.widgets.CategorySelector
> TypeError: Expecting a function in instanceof check, but got undefined

Bug: T125335
Change-Id: I6e5834c3098d00bfc75e9f6b0d61ed6e5babc6ca
---
M resources/Resources.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/Resources.php b/resources/Resources.php
index 6a22af6..6626f05 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -2031,6 +2031,8 @@
'dependencies' => array(
'oojs-ui',
'mediawiki.api',
+   'mediawiki.ForeignApi',
+   'mediawiki.Title',
),
'targets' => array( 'desktop', 'mobile' ),
),

-- 
To view, visit https://gerrit.wikimedia.org/r/274876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e5834c3098d00bfc75e9f6b0d61ed6e5babc6ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_26
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki.widgets.CategorySelector: Add missing dependency f... - change (mediawiki/core)

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/274876

Change subject: mediawiki.widgets.CategorySelector: Add missing dependency for 
ForeignApi and Title
..

mediawiki.widgets.CategorySelector: Add missing dependency for ForeignApi and 
Title

Follows-up e6d1550309 which attempted to backport 86dedeea7f but
left out the dependencies.

Fixes fatal error in REL1_26 qunit tests:
> Exception in module-execute in module mediawiki.widgets.CategorySelector
> TypeError: Expecting a function in instanceof check, but got undefined

Bug: T125335
Change-Id: I6e5834c3098d00bfc75e9f6b0d61ed6e5babc6ca
---
M resources/Resources.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/76/274876/1

diff --git a/resources/Resources.php b/resources/Resources.php
index 6a22af6..6626f05 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -2031,6 +2031,8 @@
'dependencies' => array(
'oojs-ui',
'mediawiki.api',
+   'mediawiki.ForeignApi',
+   'mediawiki.Title',
),
'targets' => array( 'desktop', 'mobile' ),
),

-- 
To view, visit https://gerrit.wikimedia.org/r/274876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e5834c3098d00bfc75e9f6b0d61ed6e5babc6ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_26
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits