[MediaWiki-commits] [Gerrit] more prints converted to stderr writes in main dump script - change (operations/dumps)
ArielGlenn has uploaded a new change for review. https://gerrit.wikimedia.org/r/62805 Change subject: more prints converted to stderr writes in main dump script .. more prints converted to stderr writes in main dump script Change-Id: Iee9c09e0c893809637cd2f4ca68929dbc4a5cbc1 --- M xmldumps-backup/worker.py 1 file changed, 25 insertions(+), 25 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/dumps refs/changes/05/62805/1 diff --git a/xmldumps-backup/worker.py b/xmldumps-backup/worker.py index 76b6e6f..08c3816 100644 --- a/xmldumps-backup/worker.py +++ b/xmldumps-backup/worker.py @@ -378,8 +378,8 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) - print Couldn't save dump run info file. Continuing anyways + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) + sys.stderr.write(Couldn't save dump run info file. Continuing anyways\n) def statusOfOldDumpIsDone(self, runner, date, jobName, jobDesc): oldDumpRunInfoFilename=self._getDumpRunInfoFileName(date) @@ -416,7 +416,7 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) return False # @@ -490,7 +490,7 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) return None # find desc in there, look for class='done' @@ -518,7 +518,7 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) return None @@ -740,12 +740,12 @@ return True if job == noop or job == latestlinks: return True - print No job of the name specified exists. Choose one of the following: - print noop (runs no job but rewrites md5sums file and resets latest links) - print latestlinks (runs no job but resets latest links) - print tables (includes all items below that end in 'table') + sys.stderr.write(No job of the name specified exists. Choose one of the following:\n) + sys.stderr.write(noop (runs no job but rewrites md5sums file and resets latest links)\n) + sys.stderr.write(latestlinks (runs no job but resets latest links)\n) + sys.stderr.write(tables (includes all items below that end in 'table')\n) for item in self.dumpItems: - print %s % item.name() + sys.stderr.write(%s\n % item.name()) return False def markFollowingJobsToRun(self): @@ -1343,7 +1343,7 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) raise BackupError(failed to rename file %s % self.filename) self.filename = os.path.join(self.dirname,newname) @@ -1411,12 +1411,12 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) message = Couldn't update status files. Continuing
[MediaWiki-commits] [Gerrit] more prints converted to stderr writes in main dump script - change (operations/dumps)
ArielGlenn has submitted this change and it was merged. Change subject: more prints converted to stderr writes in main dump script .. more prints converted to stderr writes in main dump script Change-Id: Iee9c09e0c893809637cd2f4ca68929dbc4a5cbc1 --- M xmldumps-backup/worker.py 1 file changed, 25 insertions(+), 25 deletions(-) Approvals: ArielGlenn: Looks good to me, approved jenkins-bot: Verified diff --git a/xmldumps-backup/worker.py b/xmldumps-backup/worker.py index 76b6e6f..08c3816 100644 --- a/xmldumps-backup/worker.py +++ b/xmldumps-backup/worker.py @@ -378,8 +378,8 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) - print Couldn't save dump run info file. Continuing anyways + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) + sys.stderr.write(Couldn't save dump run info file. Continuing anyways\n) def statusOfOldDumpIsDone(self, runner, date, jobName, jobDesc): oldDumpRunInfoFilename=self._getDumpRunInfoFileName(date) @@ -416,7 +416,7 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) return False # @@ -490,7 +490,7 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) return None # find desc in there, look for class='done' @@ -518,7 +518,7 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) return None @@ -740,12 +740,12 @@ return True if job == noop or job == latestlinks: return True - print No job of the name specified exists. Choose one of the following: - print noop (runs no job but rewrites md5sums file and resets latest links) - print latestlinks (runs no job but resets latest links) - print tables (includes all items below that end in 'table') + sys.stderr.write(No job of the name specified exists. Choose one of the following:\n) + sys.stderr.write(noop (runs no job but rewrites md5sums file and resets latest links)\n) + sys.stderr.write(latestlinks (runs no job but resets latest links)\n) + sys.stderr.write(tables (includes all items below that end in 'table')\n) for item in self.dumpItems: - print %s % item.name() + sys.stderr.write(%s\n % item.name()) return False def markFollowingJobsToRun(self): @@ -1343,7 +1343,7 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) raise BackupError(failed to rename file %s % self.filename) self.filename = os.path.join(self.dirname,newname) @@ -1411,12 +1411,12 @@ except: if (self.verbose): exc_type, exc_value, exc_traceback = sys.exc_info() - print repr(traceback.format_exception(exc_type, exc_value, exc_traceback)) + sys.stderr.write(repr(traceback.format_exception(exc_type, exc_value, exc_traceback))) message = Couldn't update status files. Continuing anyways if
