[MediaWiki-commits] [Gerrit] mw.Upload.BookletLayout: Pass image info when emitting the f... - change (mediawiki/core)

2015-10-20 Thread Prtksxna (Code Review) 
Prtksxna has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/247518

Change subject: mw.Upload.BookletLayout: Pass image info when emitting the 
fileSaved event
..

mw.Upload.BookletLayout: Pass image info when emitting the fileSaved event

Change-Id: Idd391382292f31d0570a6548c3b89d5e3795e832
---
M resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/18/247518/1

diff --git a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js 
b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
index 7b307ee..dd199ce 100644
--- a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
+++ b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
@@ -106,6 +106,7 @@
 * The file has been saved to the database
 *
 * @event fileSaved
+* @param {Object} imageInfo See mw.Upload#getImageInfo
 */
 
/**
@@ -234,7 +235,7 @@
layout.setPage( 'insert' );
 
deferred.resolve();
-   layout.emit( 'fileSaved' );
+   layout.emit( 'fileSaved', 
layout.upload.getImageInfo() );
}, function () {
var errorMessage = 
layout.getErrorMessageForStateDetails();
deferred.reject( errorMessage );

-- 
To view, visit https://gerrit.wikimedia.org/r/247518
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd391382292f31d0570a6548c3b89d5e3795e832
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mw.Upload.BookletLayout: Pass image info when emitting the f... - change (mediawiki/core)

2015-10-20 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: mw.Upload.BookletLayout: Pass image info when emitting the 
fileSaved event
..


mw.Upload.BookletLayout: Pass image info when emitting the fileSaved event

Don't want to reach into the layout's upload object to get this. Anything
listening to this event would want the image details.

Change-Id: Idd391382292f31d0570a6548c3b89d5e3795e832
---
M resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js 
b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
index 7b307ee..dd199ce 100644
--- a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
+++ b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js
@@ -106,6 +106,7 @@
 * The file has been saved to the database
 *
 * @event fileSaved
+* @param {Object} imageInfo See mw.Upload#getImageInfo
 */
 
/**
@@ -234,7 +235,7 @@
layout.setPage( 'insert' );
 
deferred.resolve();
-   layout.emit( 'fileSaved' );
+   layout.emit( 'fileSaved', 
layout.upload.getImageInfo() );
}, function () {
var errorMessage = 
layout.getErrorMessageForStateDetails();
deferred.reject( errorMessage );

-- 
To view, visit https://gerrit.wikimedia.org/r/247518
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd391382292f31d0570a6548c3b89d5e3795e832
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Edokter 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits