[MediaWiki-commits] [Gerrit] oojs/ui[master]: MenuTagMultiselectWidget: Don't use overlay for $autoCloseIg...

2017-12-22 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/399882 )

Change subject: MenuTagMultiselectWidget: Don't use overlay for $autoCloseIgnore
..


MenuTagMultiselectWidget: Don't use overlay for $autoCloseIgnore

If using the overlay, the menu will never close when clicking outside
of it. The overlay should be used for positioning -- the autoCloseIgnore
should include the menu itself and the input, if that exists.

Bug: T183377
Change-Id: I41ae661af6a6aa28382d485b1fd1e82777694635
---
M src/widgets/MenuTagMultiselectWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/widgets/MenuTagMultiselectWidget.js 
b/src/widgets/MenuTagMultiselectWidget.js
index d018c82..f5a87f3 100644
--- a/src/widgets/MenuTagMultiselectWidget.js
+++ b/src/widgets/MenuTagMultiselectWidget.js
@@ -43,7 +43,7 @@
$input: this.hasInput ? this.input.$input : null,
filterFromInput: !!this.hasInput,
$autoCloseIgnore: this.hasInput ?
-   this.input.$element.add( this.$overlay ) : 
this.$overlay,
+   this.input.$element : $( [] ),
$floatableContainer: this.hasInput && this.inputPosition === 
'outline' ?
this.input.$element : this.$element,
$overlay: this.$overlay,

-- 
To view, visit https://gerrit.wikimedia.org/r/399882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41ae661af6a6aa28382d485b1fd1e82777694635
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Mooeypoo 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MenuTagMultiselectWidget: Don't use overlay for $autoCloseIg...

2017-12-22 Thread Mooeypoo (Code Review) 
Mooeypoo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/399882 )

Change subject: MenuTagMultiselectWidget: Don't use overlay for $autoCloseIgnore
..

MenuTagMultiselectWidget: Don't use overlay for $autoCloseIgnore

If using the overlay, the menu will never close when clicking outside
of it. The overlay should be used for positioning -- the autoCloseIgnore
should include the menu itself and the input, if that exists.

Bug: T183377

Change-Id: I41ae661af6a6aa28382d485b1fd1e82777694635
---
M src/widgets/MenuTagMultiselectWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/82/399882/1

diff --git a/src/widgets/MenuTagMultiselectWidget.js 
b/src/widgets/MenuTagMultiselectWidget.js
index d018c82..ccb3169 100644
--- a/src/widgets/MenuTagMultiselectWidget.js
+++ b/src/widgets/MenuTagMultiselectWidget.js
@@ -43,7 +43,7 @@
$input: this.hasInput ? this.input.$input : null,
filterFromInput: !!this.hasInput,
$autoCloseIgnore: this.hasInput ?
-   this.input.$element.add( this.$overlay ) : 
this.$overlay,
+   this.input.$element.add( this.$element ) : 
this.$element,
$floatableContainer: this.hasInput && this.inputPosition === 
'outline' ?
this.input.$element : this.$element,
$overlay: this.$overlay,

-- 
To view, visit https://gerrit.wikimedia.org/r/399882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41ae661af6a6aa28382d485b1fd1e82777694635
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits