[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] SelectWidget: Remove getFirstSelectableItem

2017-12-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/376173 )

Change subject: [BREAKING CHANGE] SelectWidget: Remove getFirstSelectableItem
..


[BREAKING CHANGE] SelectWidget: Remove getFirstSelectableItem

Follows-up on Ic12be404eba490e5ce748f0d754a807e12f6ba76

Bug: T76630
Change-Id: I55294dd707df07dff5f799f3be9c0e17a99710a2
---
M src/widgets/SelectWidget.js
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index 969cc57..40b35d8 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -813,18 +813,6 @@
 };
 
 /**
- * Get the next selectable item or `null` if there are no selectable items.
- * Disabled options and menu-section markers and breaks are not selectable.
- *
- * @deprecated 0.23.1 Use {@link OO.ui.SelectWidget#findFirstSelectableItem} 
instead.
- * @return {OO.ui.OptionWidget|null} Item, `null` if there aren't any 
selectable items
- */
-OO.ui.SelectWidget.prototype.getFirstSelectableItem = function () {
-   OO.ui.warnDeprecation( 'SelectWidget#getFirstSelectableItem: Deprecated 
function. Use findFirstSelectableItem instead. See T76630.' );
-   return this.findFirstSelectableItem();
-};
-
-/**
  * Add an array of options to the select. Optionally, an index number can be 
used to
  * specify an insertion point.
  *

-- 
To view, visit https://gerrit.wikimedia.org/r/376173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I55294dd707df07dff5f799f3be9c0e17a99710a2
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [BREAKING CHANGE] SelectWidget: Remove getFirstSelectableItem

2017-09-05 Thread Prtksxna (Code Review) 
Prtksxna has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/376173 )

Change subject: [BREAKING CHANGE] SelectWidget: Remove getFirstSelectableItem
..

[BREAKING CHANGE] SelectWidget: Remove getFirstSelectableItem

Follows-up on Ic12be404eba490e5ce748f0d754a807e12f6ba76

Bug: T76630
Change-Id: I55294dd707df07dff5f799f3be9c0e17a99710a2
---
M src/widgets/SelectWidget.js
1 file changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/73/376173/1

diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index 4eba2f7..7fe3601 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -806,17 +806,6 @@
 };
 
 /**
- * Get the next selectable item or `null` if there are no selectable items.
- * Disabled options and menu-section markers and breaks are not selectable.
- *
- * @deprecated 0.24.0 Use {@link OO.ui.SelectWidget#findFirstSelectableItem} 
instead.
- * @return {OO.ui.OptionWidget|null} Item, `null` if there aren't any 
selectable items
- */
-OO.ui.SelectWidget.prototype.getFirstSelectableItem = function () {
-   return this.findFirstSelectableItem();
-};
-
-/**
  * Add an array of options to the select. Optionally, an index number can be 
used to
  * specify an insertion point.
  *

-- 
To view, visit https://gerrit.wikimedia.org/r/376173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I55294dd707df07dff5f799f3be9c0e17a99710a2
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits