[MediaWiki-commits] [Gerrit] oojs/ui[master]: Apex theme: Align readonly TextInputWidget across themes

2017-12-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/396556 )

Change subject: Apex theme: Align readonly TextInputWidget across themes
..


Apex theme: Align readonly TextInputWidget across themes

Bringing readonly TextInputWidget closer to WikimediaUI theme,
removing similarities with placeholder appearance.

Bug: T182426
Change-Id: I933ac596c0fd810c5df859b6baf385c361ab42be
---
M src/themes/apex/widgets.less
1 file changed, 10 insertions(+), 9 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, but someone else must approve



diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index d598ec2..a549604 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -1336,16 +1336,17 @@
}
 
&.oo-ui-widget-enabled {
-   input:focus,
-   textarea:focus {
-   outline: 0;
-   border-color: @border-color-base--focus;
-   box-shadow: @box-shadow-widget--focus;
-   }
+   input,
+   textarea {
+   &:focus {
+   outline: 0;
+   border-color: @border-color-base--focus;
+   box-shadow: @box-shadow-widget--focus;
+   }
 
-   input[ readonly ],
-   textarea[ readonly ] {
-   color: @color-base--read-only;
+   &[ readonly ] {
+   background-color: #f3f3f3;
+   }
}
 
&.oo-ui-flaggedElement-invalid {

-- 
To view, visit https://gerrit.wikimedia.org/r/396556
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I933ac596c0fd810c5df859b6baf385c361ab42be
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Apex theme: Align readonly TextInputWidget across themes

2017-12-08 Thread VolkerE (Code Review) 
VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396556 )

Change subject: Apex theme: Align readonly TextInputWidget across themes
..

Apex theme: Align readonly TextInputWidget across themes

Bringing readonly TextInputWidget closer to WikimediaUI theme,
removing similarities with placeholder appearance.

Bug: T182426
Change-Id: I933ac596c0fd810c5df859b6baf385c361ab42be
---
M src/themes/apex/widgets.less
1 file changed, 10 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/56/396556/1

diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index d598ec2..a549604 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -1336,16 +1336,17 @@
}
 
&.oo-ui-widget-enabled {
-   input:focus,
-   textarea:focus {
-   outline: 0;
-   border-color: @border-color-base--focus;
-   box-shadow: @box-shadow-widget--focus;
-   }
+   input,
+   textarea {
+   &:focus {
+   outline: 0;
+   border-color: @border-color-base--focus;
+   box-shadow: @box-shadow-widget--focus;
+   }
 
-   input[ readonly ],
-   textarea[ readonly ] {
-   color: @color-base--read-only;
+   &[ readonly ] {
+   background-color: #f3f3f3;
+   }
}
 
&.oo-ui-flaggedElement-invalid {

-- 
To view, visit https://gerrit.wikimedia.org/r/396556
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I933ac596c0fd810c5df859b6baf385c361ab42be
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits