[MediaWiki-commits] [Gerrit] oojs/ui[master]: Apex theme: Apply `opacity` button transition and ensure Chr...

2017-12-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395907 )

Change subject: Apex theme: Apply `opacity` button transition and ensure Chrome 
support
..


Apex theme: Apply `opacity` button transition and ensure Chrome support

With `.oo-ui-force-gpu-composite-layer()` support we are able to
provide `opacity` transition now.
Follow-up to Ied6debd7fae5a545736492776a1fd4a9e85f1f62.

Change-Id: I54e548020f5c82c60461dd552a694155fce0a811
---
M src/themes/apex/elements.less
1 file changed, 9 insertions(+), 7 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, but someone else must approve



diff --git a/src/themes/apex/elements.less b/src/themes/apex/elements.less
index 02850c0..7124f1e 100644
--- a/src/themes/apex/elements.less
+++ b/src/themes/apex/elements.less
@@ -39,9 +39,15 @@
 
&-frameless {
> .oo-ui-buttonElement-button {
-   // Don't animate `.oo-ui-iconElement-icon` `opacity` 
for now,
-   // causes wiggling in Chrome, see T65020
-   // `.oo-ui-transition( opacity @medium-ease );`
+   > .oo-ui-iconElement-icon {
+   .oo-ui-transition( opacity @medium-ease );
+   // Support Webkit/Blink: `opacity` < 1 causes 
wiggling, see T65020
+   .oo-ui-force-gpu-composite-layer();
+   }
+
+   > .oo-ui-labelElement-label {
+   color: @color-base;
+   }
 
&:hover,
&:focus {
@@ -52,10 +58,6 @@
> .oo-ui-labelElement-label {
color: #000;
}
-   }
-
-   > .oo-ui-labelElement-label {
-   color: @color-base;
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/395907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54e548020f5c82c60461dd552a694155fce0a811
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Apex theme: Apply `opacity` button transition and ensure Chr...

2017-12-06 Thread VolkerE (Code Review) 
VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395907 )

Change subject: Apex theme: Apply `opacity` button transition and ensure Chrome 
support
..

Apex theme: Apply `opacity` button transition and ensure Chrome support

With `.oo-ui-force-gpu-composite-layer()` support we are able to
provide `opacity` transition now.
Follow-up to Ied6debd7fae5a545736492776a1fd4a9e85f1f62.

Change-Id: I54e548020f5c82c60461dd552a694155fce0a811
---
M src/themes/apex/elements.less
1 file changed, 9 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/07/395907/1

diff --git a/src/themes/apex/elements.less b/src/themes/apex/elements.less
index 02850c0..7124f1e 100644
--- a/src/themes/apex/elements.less
+++ b/src/themes/apex/elements.less
@@ -39,9 +39,15 @@
 
&-frameless {
> .oo-ui-buttonElement-button {
-   // Don't animate `.oo-ui-iconElement-icon` `opacity` 
for now,
-   // causes wiggling in Chrome, see T65020
-   // `.oo-ui-transition( opacity @medium-ease );`
+   > .oo-ui-iconElement-icon {
+   .oo-ui-transition( opacity @medium-ease );
+   // Support Webkit/Blink: `opacity` < 1 causes 
wiggling, see T65020
+   .oo-ui-force-gpu-composite-layer();
+   }
+
+   > .oo-ui-labelElement-label {
+   color: @color-base;
+   }
 
&:hover,
&:focus {
@@ -52,10 +58,6 @@
> .oo-ui-labelElement-label {
color: #000;
}
-   }
-
-   > .oo-ui-labelElement-label {
-   color: @color-base;
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/395907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54e548020f5c82c60461dd552a694155fce0a811
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits