[MediaWiki-commits] [Gerrit] oojs/ui[master]: ClippableElement: Add `min-height` for usability in edge cases

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330351 )

Change subject: ClippableElement: Add `min-height` for usability in edge cases
..


ClippableElement: Add `min-height` for usability in edge cases

Adding `min-height` of 40px to ClippableElement in order to
provide pointer and touch usability.

Bug: T113050
Bug: T146531
Change-Id: Ib7effc496fdfff36cc2808a5d22de132509d8dc5
---
M src/styles/elements/ClippableElement.less
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  Prtksxna: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/src/styles/elements/ClippableElement.less 
b/src/styles/elements/ClippableElement.less
index 5b8cd84..3d1485f 100644
--- a/src/styles/elements/ClippableElement.less
+++ b/src/styles/elements/ClippableElement.less
@@ -2,6 +2,7 @@
 
 .oo-ui-clippableElement-clippable {
.oo-ui-box-sizing( border-box );
+   min-height: 3.125em; // equals `40px` at base `font-size: 12.8px`
 
.theme-oo-ui-clippableElement();
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/330351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7effc496fdfff36cc2808a5d22de132509d8dc5
Gerrit-PatchSet: 4
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: ClippableElement: Add `min-height` for usability in edge cases

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/330351 )

Change subject: ClippableElement: Add `min-height` for usability in edge cases
..

ClippableElement: Add `min-height` for usability in edge cases

Bug: T146531
Change-Id: Ib7effc496fdfff36cc2808a5d22de132509d8dc5
---
M src/styles/elements/ClippableElement.less
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/51/330351/1

diff --git a/src/styles/elements/ClippableElement.less 
b/src/styles/elements/ClippableElement.less
index 5b8cd84..ac61092 100644
--- a/src/styles/elements/ClippableElement.less
+++ b/src/styles/elements/ClippableElement.less
@@ -2,6 +2,7 @@
 
 .oo-ui-clippableElement-clippable {
.oo-ui-box-sizing( border-box );
+   min-height: 2.5em; // equals `32px` at base `font-size: 12.8px`
 
.theme-oo-ui-clippableElement();
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/330351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7effc496fdfff36cc2808a5d22de132509d8dc5
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits