[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Increase contrast slightly on non-primary, ...

2017-04-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/349027 )

Change subject: MediaWiki theme: Increase contrast slightly on non-primary, 
destructive buttons
..


MediaWiki theme: Increase contrast slightly on non-primary, destructive buttons

Make them conform to WCAG 2.0 level AA by using adapted shade of Red50 `#d33`.

Change-Id: Ibcffd71fd1200b1987931135d3441db689d0dcd4
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/elements.less
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 49cf417..0907636 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -27,6 +27,7 @@
 
 @background-color-destructive: #fbe8e7; // equals `fade( @color-destructive, 
10% )`
 @color-destructive: #d33; // equals HSB 360°/77%/87%
+@color-destructive-non-primary: #d7; // Exemption for non-primary buttons, 
foremost used in VE, lightened up R50 to align to AA contrast ratio
 @color-destructive-hover: #ff4242; // equals HSB 360°/74%/100%
 @color-destructive-active: #b32424; // equals HSB 360°/80%/70%
 @color-destructive-focus: @color-destructive;
diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index ff51236..24c79cb 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -326,7 +326,7 @@
}
 
&-destructive {
-   .mw-framed-button-colored( 
~'.oo-ui-buttonElement-button', @color-destructive, 
@background-color-framed-hover, @border-color-framed-destructive-hover, 
@color-destructive-active, @color-destructive-focus );
+   .mw-framed-button-colored( 
~'.oo-ui-buttonElement-button', @color-destructive-non-primary, 
@background-color-framed-hover, @border-color-framed-destructive-hover, 
@color-destructive-active, @color-destructive-focus );
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/349027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcffd71fd1200b1987931135d3441db689d0dcd4
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Increase contrast slightly on non-primary, ...

2017-04-19 Thread VolkerE (Code Review) 
VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/349027 )

Change subject: MediaWiki theme: Increase contrast slightly on non-primary, 
destructive buttons
..

MediaWiki theme: Increase contrast slightly on non-primary, destructive buttons

Make them conform to WCAG 2.0 level AA by using adapted shade of Red50 `#d33`.

Change-Id: Ibcffd71fd1200b1987931135d3441db689d0dcd4
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/elements.less
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/27/349027/1

diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 49cf417..0907636 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -27,6 +27,7 @@
 
 @background-color-destructive: #fbe8e7; // equals `fade( @color-destructive, 
10% )`
 @color-destructive: #d33; // equals HSB 360°/77%/87%
+@color-destructive-non-primary: #d7; // Exemption for non-primary buttons, 
foremost used in VE, lightened up R50 to align to AA contrast ratio
 @color-destructive-hover: #ff4242; // equals HSB 360°/74%/100%
 @color-destructive-active: #b32424; // equals HSB 360°/80%/70%
 @color-destructive-focus: @color-destructive;
diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index ff51236..24c79cb 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -326,7 +326,7 @@
}
 
&-destructive {
-   .mw-framed-button-colored( 
~'.oo-ui-buttonElement-button', @color-destructive, 
@background-color-framed-hover, @border-color-framed-destructive-hover, 
@color-destructive-active, @color-destructive-focus );
+   .mw-framed-button-colored( 
~'.oo-ui-buttonElement-button', @color-destructive-non-primary, 
@background-color-framed-hover, @border-color-framed-destructive-hover, 
@color-destructive-active, @color-destructive-focus );
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/349027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcffd71fd1200b1987931135d3441db689d0dcd4
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits