[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Fix visual glitch on `:active:focus` widget...

2016-11-08 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: MediaWiki theme: Fix visual glitch on `:active:focus` widgets 
state
..


MediaWiki theme: Fix visual glitch on `:active:focus` widgets state

Fixing visual glitch on `:active:focus` state in CheckboxInput- and
RadioInputWidget. `:active` state should not feature `:hover` or
`:focus` colors. Similar to Ifc2e0d619b46011af840df663ca93882480c4fff

Change-Id: Id29445aa9ad976c09832d660e7a7f0bcbf4cbb67
---
M src/themes/mediawiki/widgets.less
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index 3753f7a..300edaa 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -484,9 +484,11 @@
}
 
&:active + span,
-   &:active:hover + span {
+   &:active:hover + span,
+   &:active:focus + span {
background-color: 
@background-color-input-binary-active;
border-color: @border-color-input-binary-active;
+   box-shadow: @box-shadow-active;
}
 
&:focus + span {
@@ -663,6 +665,10 @@
&:active:focus + span {
border-color: @border-color-input-binary-active;
box-shadow: inset 0 0 0 1px 
@border-color-input-binary-active;
+
+   &:before {
+   border-color: 
@border-color-input-binary-active;
+   }
}
 
&:focus + span {

-- 
To view, visit https://gerrit.wikimedia.org/r/320518
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id29445aa9ad976c09832d660e7a7f0bcbf4cbb67
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Fix visual glitch on `:active:focus` widget...

2016-11-08 Thread VolkerE (Code Review) 
VolkerE has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/320518

Change subject: MediaWiki theme: Fix visual glitch on `:active:focus` widgets 
state
..

MediaWiki theme: Fix visual glitch on `:active:focus` widgets state

Fixing visual glitch on `:active:focus` state in CheckboxInput- and
RadioInputWidget. `:active` state should not feature `:hover` or
`:focus` colors. Similar to Ifc2e0d619b46011af840df663ca93882480c4fff

Change-Id: Id29445aa9ad976c09832d660e7a7f0bcbf4cbb67
---
M src/themes/mediawiki/widgets.less
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/18/320518/1

diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index 3753f7a..300edaa 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -484,9 +484,11 @@
}
 
&:active + span,
-   &:active:hover + span {
+   &:active:hover + span,
+   &:active:focus + span {
background-color: 
@background-color-input-binary-active;
border-color: @border-color-input-binary-active;
+   box-shadow: @box-shadow-active;
}
 
&:focus + span {
@@ -663,6 +665,10 @@
&:active:focus + span {
border-color: @border-color-input-binary-active;
box-shadow: inset 0 0 0 1px 
@border-color-input-binary-active;
+
+   &:before {
+   border-color: 
@border-color-input-binary-active;
+   }
}
 
&:focus + span {

-- 
To view, visit https://gerrit.wikimedia.org/r/320518
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id29445aa9ad976c09832d660e7a7f0bcbf4cbb67
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits