[MediaWiki-commits] [Gerrit] oojs/ui[master]: Use findItem(s)FromData instead of getItem(s)FromData
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/398209 )
Change subject: Use findItem(s)FromData instead of getItem(s)FromData
..
Use findItem(s)FromData instead of getItem(s)FromData
Follows-up on Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Bug: T76630
Change-Id: I1ae2c3da6d1bf1b5c45f8937797661b3c10cd03a
---
M demos/classes/IndexedDialog.js
M src/layouts/BookletLayout.js
M src/layouts/IndexLayout.js
M src/widgets/CapsuleMultiselectWidget.js
M src/widgets/CheckboxMultiselectInputWidget.js
M src/widgets/ComboBoxInputWidget.js
M src/widgets/DropdownInputWidget.js
M src/widgets/MenuTagMultiselectWidget.js
M src/widgets/MultiselectWidget.js
M src/widgets/RadioSelectInputWidget.js
M src/widgets/SelectWidget.js
M src/widgets/TagMultiselectWidget.js
12 files changed, 25 insertions(+), 25 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/demos/classes/IndexedDialog.js b/demos/classes/IndexedDialog.js
index c2d437f..ac93224 100644
--- a/demos/classes/IndexedDialog.js
+++ b/demos/classes/IndexedDialog.js
@@ -33,7 +33,7 @@
this.indexLayout.addTabPanels( this.tabPanels );
this.$body.append( this.indexLayout.$element );
- this.indexLayout.getTabs().getItemFromData( 'fourth' ).setDisabled(
true );
+ this.indexLayout.getTabs().findItemFromData( 'fourth' ).setDisabled(
true );
};
Demo.IndexedDialog.prototype.getActionProcess = function ( action ) {
if ( action ) {
diff --git a/src/layouts/BookletLayout.js b/src/layouts/BookletLayout.js
index 4fb4d5b..c53017a 100644
--- a/src/layouts/BookletLayout.js
+++ b/src/layouts/BookletLayout.js
@@ -323,16 +323,16 @@
prev = pages[ index - 1 ];
// Prefer adjacent pages at the same level
if ( this.outlined ) {
- level = this.outlineSelectWidget.getItemFromData(
page.getName() ).getLevel();
+ level = this.outlineSelectWidget.findItemFromData(
page.getName() ).getLevel();
if (
prev &&
- level ===
this.outlineSelectWidget.getItemFromData( prev.getName() ).getLevel()
+ level ===
this.outlineSelectWidget.findItemFromData( prev.getName() ).getLevel()
) {
return prev;
}
if (
next &&
- level ===
this.outlineSelectWidget.getItemFromData( next.getName() ).getLevel()
+ level ===
this.outlineSelectWidget.findItemFromData( next.getName() ).getLevel()
) {
return next;
}
@@ -467,7 +467,7 @@
name = page.getName();
delete this.pages[ name ];
if ( this.outlined ) {
- items.push( this.outlineSelectWidget.getItemFromData(
name ) );
+ items.push( this.outlineSelectWidget.findItemFromData(
name ) );
page.setOutlineItem( null );
}
}
diff --git a/src/layouts/IndexLayout.js b/src/layouts/IndexLayout.js
index 22bcc1a..12fb1b5 100644
--- a/src/layouts/IndexLayout.js
+++ b/src/layouts/IndexLayout.js
@@ -213,16 +213,16 @@
next = tabPanels[ index + 1 ];
prev = tabPanels[ index - 1 ];
// Prefer adjacent tab panels at the same level
- level = this.tabSelectWidget.getItemFromData(
tabPanel.getName() ).getLevel();
+ level = this.tabSelectWidget.findItemFromData(
tabPanel.getName() ).getLevel();
if (
prev &&
- level === this.tabSelectWidget.getItemFromData(
prev.getName() ).getLevel()
+ level === this.tabSelectWidget.findItemFromData(
prev.getName() ).getLevel()
) {
return prev;
}
if (
next &&
- level === this.tabSelectWidget.getItemFromData(
next.getName() ).getLevel()
+ level === this.tabSelectWidget.findItemFromData(
next.getName() ).getLevel()
) {
return next;
}
@@ -340,7 +340,7 @@
tabPanel = tabPanels[ i ];
name = tabPanel.getName();
delete this.tabPanels[ name ];
- items.push( this.tabSelectWidget.getItemFromData( name ) );
+ items.push( this.tabSelectWidget.findItemFromData( name ) );
tabPanel.setTabItem( null );
}
if ( items.length ) {
diff --git a/src/widgets/CapsuleMultiselectWidget.js
b/src/widgets/CapsuleMultiselectWid
[MediaWiki-commits] [Gerrit] oojs/ui[master]: Use findItem(s)FromData instead of getItem(s)FromData
Prtksxna has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398209 )
Change subject: Use findItem(s)FromData instead of getItem(s)FromData
..
Use findItem(s)FromData instead of getItem(s)FromData
Bug: T76630
Change-Id: I1ae2c3da6d1bf1b5c45f8937797661b3c10cd03a
---
M demos/classes/IndexedDialog.js
M src/layouts/BookletLayout.js
M src/layouts/IndexLayout.js
M src/widgets/CapsuleMultiselectWidget.js
M src/widgets/CheckboxMultiselectInputWidget.js
M src/widgets/ComboBoxInputWidget.js
M src/widgets/DropdownInputWidget.js
M src/widgets/MenuTagMultiselectWidget.js
M src/widgets/MultiselectWidget.js
M src/widgets/RadioSelectInputWidget.js
M src/widgets/SelectWidget.js
M src/widgets/TagMultiselectWidget.js
12 files changed, 25 insertions(+), 25 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/09/398209/1
diff --git a/demos/classes/IndexedDialog.js b/demos/classes/IndexedDialog.js
index c2d437f..ac93224 100644
--- a/demos/classes/IndexedDialog.js
+++ b/demos/classes/IndexedDialog.js
@@ -33,7 +33,7 @@
this.indexLayout.addTabPanels( this.tabPanels );
this.$body.append( this.indexLayout.$element );
- this.indexLayout.getTabs().getItemFromData( 'fourth' ).setDisabled(
true );
+ this.indexLayout.getTabs().findItemFromData( 'fourth' ).setDisabled(
true );
};
Demo.IndexedDialog.prototype.getActionProcess = function ( action ) {
if ( action ) {
diff --git a/src/layouts/BookletLayout.js b/src/layouts/BookletLayout.js
index 4fb4d5b..c53017a 100644
--- a/src/layouts/BookletLayout.js
+++ b/src/layouts/BookletLayout.js
@@ -323,16 +323,16 @@
prev = pages[ index - 1 ];
// Prefer adjacent pages at the same level
if ( this.outlined ) {
- level = this.outlineSelectWidget.getItemFromData(
page.getName() ).getLevel();
+ level = this.outlineSelectWidget.findItemFromData(
page.getName() ).getLevel();
if (
prev &&
- level ===
this.outlineSelectWidget.getItemFromData( prev.getName() ).getLevel()
+ level ===
this.outlineSelectWidget.findItemFromData( prev.getName() ).getLevel()
) {
return prev;
}
if (
next &&
- level ===
this.outlineSelectWidget.getItemFromData( next.getName() ).getLevel()
+ level ===
this.outlineSelectWidget.findItemFromData( next.getName() ).getLevel()
) {
return next;
}
@@ -467,7 +467,7 @@
name = page.getName();
delete this.pages[ name ];
if ( this.outlined ) {
- items.push( this.outlineSelectWidget.getItemFromData(
name ) );
+ items.push( this.outlineSelectWidget.findItemFromData(
name ) );
page.setOutlineItem( null );
}
}
diff --git a/src/layouts/IndexLayout.js b/src/layouts/IndexLayout.js
index 22bcc1a..12fb1b5 100644
--- a/src/layouts/IndexLayout.js
+++ b/src/layouts/IndexLayout.js
@@ -213,16 +213,16 @@
next = tabPanels[ index + 1 ];
prev = tabPanels[ index - 1 ];
// Prefer adjacent tab panels at the same level
- level = this.tabSelectWidget.getItemFromData(
tabPanel.getName() ).getLevel();
+ level = this.tabSelectWidget.findItemFromData(
tabPanel.getName() ).getLevel();
if (
prev &&
- level === this.tabSelectWidget.getItemFromData(
prev.getName() ).getLevel()
+ level === this.tabSelectWidget.findItemFromData(
prev.getName() ).getLevel()
) {
return prev;
}
if (
next &&
- level === this.tabSelectWidget.getItemFromData(
next.getName() ).getLevel()
+ level === this.tabSelectWidget.findItemFromData(
next.getName() ).getLevel()
) {
return next;
}
@@ -340,7 +340,7 @@
tabPanel = tabPanels[ i ];
name = tabPanel.getName();
delete this.tabPanels[ name ];
- items.push( this.tabSelectWidget.getItemFromData( name ) );
+ items.push( this.tabSelectWidget.findItemFromData( name ) );
tabPanel.setTabItem( null );
}
if ( items.length ) {
diff --git a/src/widgets/CapsuleMultiselectWidget.js
b/src/widgets/CapsuleMultiselectWidget.js
index 5509050..e515a8b 100644
--- a/src/widgets/CapsuleMultis
