[MediaWiki-commits] [Gerrit] oojs/ui[master]: demo: Use longer text in popup in $overlay demo

2017-02-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/337069 )

Change subject: demo: Use longer text in popup in $overlay demo
..


demo: Use longer text in popup in $overlay demo

It's a lot easier to test the clipping behavior when the text is
actually longer than a single line.

Change-Id: I0da510eceb53e96c9dd18cfa59750f38a56ea6a9
---
M demos/pages/dialogs.js
1 file changed, 7 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/demos/pages/dialogs.js b/demos/pages/dialogs.js
index f48d456..0bf3c59 100644
--- a/demos/pages/dialogs.js
+++ b/demos/pages/dialogs.js
@@ -660,7 +660,7 @@
label: 'Popup button',
popup: {
padded: true,
-   $content: $( '' ).text( 
'Popup contents.' )
+   $content: this.makeContents()
}
} ), $spacer.clone() ]
} ),
@@ -671,7 +671,7 @@
label: 'Popup button',
popup: {
padded: true,
-   $content: $( '' ).text( 
'Popup contents.' )
+   $content: this.makeContents()
}
} ), $spacer.clone() ]
} ),
@@ -719,6 +719,11 @@
} );
} );
};
+   DialogWithDropdowns.prototype.makeContents = function () {
+   var loremIpsum = 'Lorem ipsum dolor sit amet, consectetur 
adipisicing elit, ' +
+   'sed do eiusmod tempor incididunt ut labore et dolore 
magna aliqua.\u200E';
+   return $( '' ).text( loremIpsum );
+   };
 
DialogWithDropdowns.prototype.getActionProcess = function ( action ) {
if ( action ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/337069
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0da510eceb53e96c9dd18cfa59750f38a56ea6a9
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: demo: Use longer text in popup in $overlay demo

2017-02-10 Thread Code Review 
Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/337069 )

Change subject: demo: Use longer text in popup in $overlay demo
..

demo: Use longer text in popup in $overlay demo

It's a lot easier to test the clipping behavior when the text is
actually longer than a single line.

Change-Id: I0da510eceb53e96c9dd18cfa59750f38a56ea6a9
---
M demos/pages/dialogs.js
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/69/337069/1

diff --git a/demos/pages/dialogs.js b/demos/pages/dialogs.js
index f48d456..0bf3c59 100644
--- a/demos/pages/dialogs.js
+++ b/demos/pages/dialogs.js
@@ -660,7 +660,7 @@
label: 'Popup button',
popup: {
padded: true,
-   $content: $( '' ).text( 
'Popup contents.' )
+   $content: this.makeContents()
}
} ), $spacer.clone() ]
} ),
@@ -671,7 +671,7 @@
label: 'Popup button',
popup: {
padded: true,
-   $content: $( '' ).text( 
'Popup contents.' )
+   $content: this.makeContents()
}
} ), $spacer.clone() ]
} ),
@@ -719,6 +719,11 @@
} );
} );
};
+   DialogWithDropdowns.prototype.makeContents = function () {
+   var loremIpsum = 'Lorem ipsum dolor sit amet, consectetur 
adipisicing elit, ' +
+   'sed do eiusmod tempor incididunt ut labore et dolore 
magna aliqua.\u200E';
+   return $( '' ).text( loremIpsum );
+   };
 
DialogWithDropdowns.prototype.getActionProcess = function ( action ) {
if ( action ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/337069
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0da510eceb53e96c9dd18cfa59750f38a56ea6a9
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits