jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/398193 )
Change subject: demos: Override OO.ui.getViewportSpacing in infused PHP demo too
......................................................................
demos: Override OO.ui.getViewportSpacing in infused PHP demo too
The widgets should not overlap the fixed header when they are infused.
Follow-up to 85bcb4d71.
Change-Id: I32258e263460b8791e20098b55ada6dbaa1a3039
---
M demos/infusion.js
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/demos/infusion.js b/demos/infusion.js
index dcf8c12..1374b9a 100644
--- a/demos/infusion.js
+++ b/demos/infusion.js
@@ -1,7 +1,7 @@
// Demonstrate JavaScript 'infusion' of PHP-generated widgets.
// Used by widgets.php.
-var infuseButton;
+var infuseButton, $demoMenu;
// Helper function to get high resolution profiling data, where available.
function now() {
@@ -24,6 +24,17 @@
infuseButton.setDisabled( true );
}
+$demoMenu = $( '.demo-menu' );
+
+OO.ui.getViewportSpacing = function () {
+ return {
+ top: $demoMenu.outerHeight(),
+ right: 0,
+ bottom: 0,
+ left: 0
+ };
+};
+
// More typical usage: we take the existing server-side
// button group and do things to it, here adding a new button.
infuseButton = new OO.ui.ButtonWidget( { label: 'Infuse' } )
--
To view, visit https://gerrit.wikimedia.org/r/398193
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32258e263460b8791e20098b55ada6dbaa1a3039
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
