Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373171 )
Change subject: WIP (DO NOT MERGE): pagePreviews: remove invalidated popup sampling rate variables ...................................................................... WIP (DO NOT MERGE): pagePreviews: remove invalidated popup sampling rate variables The page preview sampling rate configurations for the schema and anonymous users no longer seems necessary after 100% roll-out. Bug: T171853 Change-Id: Icf87741cc8f03a4dd947b659422e7856c56de44f --- M wmf-config/InitialiseSettings-labs.php M wmf-config/InitialiseSettings.php 2 files changed, 0 insertions(+), 41 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/71/373171/1 diff --git a/wmf-config/InitialiseSettings-labs.php b/wmf-config/InitialiseSettings-labs.php index c20bd91..e37538c 100644 --- a/wmf-config/InitialiseSettings-labs.php +++ b/wmf-config/InitialiseSettings-labs.php @@ -560,9 +560,6 @@ ], // To allow us to test EventLogging in the beta cluster we log all events - 'wgPopupsSchemaSamplingRate' => [ - 'default' => 1, - ], 'wgPopupsStatsvSamplingRate' => [ 'default' => 1, ], @@ -579,9 +576,6 @@ ], 'wmgPopupsBetaFeature' => [ 'default' => false, - ], - 'wgPopupsAnonsEnabledSamplingRate' => [ - 'default' => 1, ], 'wmgUseCollaborationKit' => [ diff --git a/wmf-config/InitialiseSettings.php b/wmf-config/InitialiseSettings.php index 93037ca..c3302b0 100644 --- a/wmf-config/InitialiseSettings.php +++ b/wmf-config/InitialiseSettings.php @@ -13572,20 +13572,6 @@ 'Special:CiteThisPage', ], ], -'wgPopupsAnonsEnabledSamplingRate' => [ - 'default' => 0, - 'sewikimedia' => 1, // T68374 - - // T136602: Make Page Previews enabled by default for 90% of anon users for - // the stage 0 wikis. - 'pp_stage0' => 0.9, - - // T162672: Make Page Previews enabled by default for the stage 1 wikis. - 'pp_stage1' => 1, - - 'enwiki' => 0, - 'dewiki' => 0, -], 'wmgPopupsBetaFeature' => [ 'default' => true, @@ -13610,27 +13596,6 @@ 'enwiki' => true, 'dewiki' => true, -], - - // Careful! This value should not be increased without coordination with the - // Operations and/or Analytics teams. At the very least, be mindful of the - // current rate of Popups events being logged: - // https://grafana.wikimedia.org/dashboard/db/eventlogging-schema?var-schema=Popups -'wgPopupsSchemaSamplingRate' => [ - 'default' => 0.000, - - 'pp_stage0' => 0.001, - - // T171325: Increase the per-session sampling rate of the Page Previews - // EventLogging instrumentation to 1% of all distinct browser sessions so - // that analysis of the stage 0 test can be completed in a reasonable amount - // of time. - 'itwiki' => 0.01, - 'huwiki' => 0.01, - 'ruwiki' => 0.01, - - 'enwiki' => 0, - 'dewiki' => 0, ], 'wgPopupsStatsvSamplingRate' => [ -- To view, visit https://gerrit.wikimedia.org/r/373171 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf87741cc8f03a4dd947b659422e7856c56de44f Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits