[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: load ActiveAbtract extension explicitly so class autoloading...

2018-01-10 Thread 20after4 (Code Review)
20after4 has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403114 )

Change subject: load ActiveAbtract extension explicitly so class autoloading 
works
..


load ActiveAbtract extension explicitly so class autoloading works

Needed for abstracts dumps, we only load it for php from the cli,
since that's the only time we want it.

Bug: T184177
Change-Id: I8da76b4f03afccc553da586084600885eda5c866
---
M wmf-config/CommonSettings.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Brion VIBBER: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, but someone else must approve
  20after4: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 2fb13e7..7959ed9 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -3627,6 +3627,10 @@
wfLoadExtension( 'ReadingLists' );
 }
 
+if ( PHP_SAPI === 'cli' ) {
+   wfLoadExtension( 'ActiveAbstract' );
+}
+
 if ( $wmfRealm === 'labs' ) {
require "$wmfConfigDir/CommonSettings-labs.php";
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/403114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8da76b4f03afccc553da586084600885eda5c866
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: ArielGlenn 
Gerrit-Reviewer: 20after4 
Gerrit-Reviewer: ArielGlenn 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: load ActiveAbtract extension explicitly so class autoloading...

2018-01-09 Thread ArielGlenn (Code Review)
ArielGlenn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403114 )

Change subject: load ActiveAbtract extension explicitly so class autoloading 
works
..

load ActiveAbtract extension explicitly so class autoloading works

Needed for abstracts dumps, we only load it for php from the cli,
since that's the only time we want it.

Bug: T184177
Change-Id: I8da76b4f03afccc553da586084600885eda5c866
---
M wmf-config/CommonSettings.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/14/403114/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 7c6c058..1a83fd6 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -3627,6 +3627,10 @@
wfLoadExtension( 'ReadingLists' );
 }
 
+if ( PHP_SAPI === 'cli' ) {
+   wfLoadExtension( 'ActiveAbstract' );
+}
+
 if ( $wmfRealm === 'labs' ) {
require "$wmfConfigDir/CommonSettings-labs.php";
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/403114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8da76b4f03afccc553da586084600885eda5c866
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: ArielGlenn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits