[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: phpunit: Add test to verify computed lists are up to date

2017-02-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/337078 )

Change subject: phpunit: Add test to verify computed lists are up to date
..


phpunit: Add test to verify computed lists are up to date

Change-Id: I41b09873feb552296da811a442246ea77c6f109b
---
M tests/dblistTest.php
1 file changed, 23 insertions(+), 0 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/dblistTest.php b/tests/dblistTest.php
index 0f0b39d..92beca0 100644
--- a/tests/dblistTest.php
+++ b/tests/dblistTest.php
@@ -85,7 +85,30 @@
"'{$dbfile}.dblist' contains names not in 
'all.dblist'"
);
}
+   }
 
+   public function testComputedListsFreshness() {
+   $lists = DBList::getLists();
+   foreach ( $lists as $listname => $dbnames ) {
+   if ( strpos( $listname, 'computed' ) !== false ) {
+   if ( strpos( $listname, 'labs' ) !== false ) {
+   continue;
+   }
+   $suffix = '-computed';
+   $expandedListName = str_replace( $suffix, '', 
$listname );
+   $this->assertEquals(
+   $suffix,
+   substr( $listname, -strlen( $suffix ) ),
+   "Computed list name '$listname' must 
end with '$suffix'"
+   );
+   $expandedList = MWWikiversions::readDbListFile( 
$expandedListName );
+   $this->assertEquals(
+   $expandedList,
+   $dbnames,
+   "Contents of '$expandedListName' must 
match expansion of '$listname'"
+   );
+   }
+   }
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/337078
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41b09873feb552296da811a442246ea77c6f109b
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: phpunit: Add test to verify computed lists are up to date

2017-02-10 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/337078 )

Change subject: phpunit: Add test to verify computed lists are up to date
..

phpunit: Add test to verify computed lists are up to date

Change-Id: I41b09873feb552296da811a442246ea77c6f109b
---
M tests/dblistTest.php
1 file changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/78/337078/1

diff --git a/tests/dblistTest.php b/tests/dblistTest.php
index 0f0b39d..92beca0 100644
--- a/tests/dblistTest.php
+++ b/tests/dblistTest.php
@@ -85,7 +85,30 @@
"'{$dbfile}.dblist' contains names not in 
'all.dblist'"
);
}
+   }
 
+   public function testComputedListsFreshness() {
+   $lists = DBList::getLists();
+   foreach ( $lists as $listname => $dbnames ) {
+   if ( strpos( $listname, 'computed' ) !== false ) {
+   if ( strpos( $listname, 'labs' ) !== false ) {
+   continue;
+   }
+   $suffix = '-computed';
+   $expandedListName = str_replace( $suffix, '', 
$listname );
+   $this->assertEquals(
+   $suffix,
+   substr( $listname, -strlen( $suffix ) ),
+   "Computed list name '$listname' must 
end with '$suffix'"
+   );
+   $expandedList = MWWikiversions::readDbListFile( 
$expandedListName );
+   $this->assertEquals(
+   $expandedList,
+   $dbnames,
+   "Contents of '$expandedListName' must 
match expansion of '$listname'"
+   );
+   }
+   }
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/337078
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41b09873feb552296da811a442246ea77c6f109b
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits