[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: wikitech: Align 'contentadmin' and 'sysop' permissions

2017-10-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/382024 )

Change subject: wikitech: Align 'contentadmin' and 'sysop' permissions
..


wikitech: Align 'contentadmin' and 'sysop' permissions

Three user rights are assigned to sysop's in some extension.json, which is
parsed after the configuration files are read. Hence those aren't
automatically added to contentadmins in the first line (assigning all
sysop permissions to contentadmin). Grant those explicitely. These are:
- Mass delete pages (nuke)
- Send a message to multiple users at once (massmessage)
- View the spam blacklist log (spamblacklistlog)

Also, the user right 'editrestrictedfield' is explicitely removed from
contentadmins. This used to be a right in use with PageForms, an
extension which has been undeployed from wikitech. Removing that line is
just cleanup.

Bug: T171208
Change-Id: I62e8a93760b639cdf0c60f13d117c74065030414
---
M wmf-config/CommonSettings.php
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Thcipriani: Looks good to me, approved
  BryanDavis: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Zoranzoki21: Looks good to me, but someone else must approve



diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index c932ae9..d53b1de 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -2808,13 +2808,17 @@
$wgGroupPermissions['contentadmin'] = $wgGroupPermissions['sysop'];
$wgGroupPermissions['contentadmin']['editusercss'] = false;
$wgGroupPermissions['contentadmin']['edituserjs'] = false;
-   $wgGroupPermissions['contentadmin']['editrestrictedfield'] = false;
$wgGroupPermissions['contentadmin']['editinterface'] = false;
$wgGroupPermissions['contentadmin']['tboverride'] = false;
$wgGroupPermissions['contentadmin']['titleblacklistlog'] = false;
$wgGroupPermissions['contentadmin']['override-antispoof'] = false;
$wgGroupPermissions['contentadmin']['createaccount'] = false;
 
+   // These are somehow not added as they are assigned to 'sysop' in the 
respective extension.json
+   $wgGroupPermissions['contentadmin']['nuke'] = true;
+   $wgGroupPermissions['contentadmin']['massmessage'] = true;
+   $wgGroupPermissions['contentadmin']['spamblacklistlog'] = true;
+
$wgMessageCacheType = 'memcached-pecl';
 
if ( $wgDBname === 'labswiki' ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/382024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62e8a93760b639cdf0c60f13d117c74065030414
Gerrit-PatchSet: 3
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: EddieGP 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: wikitech: Align 'contentadmin' and 'sysop' permissions

2017-10-03 Thread EddieGP (Code Review) 
EddieGP has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/382024 )

Change subject: wikitech: Align 'contentadmin' and 'sysop' permissions
..

wikitech: Align 'contentadmin' and 'sysop' permissions

Three user rights are assigned to sysop's in some extension.json, which is
parsed after the configuration files are read. Hence those aren't
automatically added to contentadmins in the first line (assigning all
sysop permissions to contentadmin). Grant those explicitely. These are:
- Mass delete pages (nuke)
- Send a message to multiple users at once (massmessage)
- View the spam blacklist log (spamblacklistlog)

Also, the user right 'editrestrictedfield' is explicitely removed from
contentadmins. This used to be a right in use with PageForms, an
extension which has been undeployed from wikitech. Removing that line is
just cleanup.

Bug: T171208
Change-Id: I62e8a93760b639cdf0c60f13d117c74065030414
---
M wmf-config/CommonSettings.php
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/24/382024/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index 62cfa4e..629bb99 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -2810,13 +2810,17 @@
$wgGroupPermissions['contentadmin'] = $wgGroupPermissions['sysop'];
$wgGroupPermissions['contentadmin']['editusercss'] = false;
$wgGroupPermissions['contentadmin']['edituserjs'] = false;
-   $wgGroupPermissions['contentadmin']['editrestrictedfield'] = false;
$wgGroupPermissions['contentadmin']['editinterface'] = false;
$wgGroupPermissions['contentadmin']['tboverride'] = false;
$wgGroupPermissions['contentadmin']['titleblacklistlog'] = false;
$wgGroupPermissions['contentadmin']['override-antispoof'] = false;
$wgGroupPermissions['contentadmin']['createaccount'] = false;
 
+   // These are somehow not added as they are assigned to 'sysop' in the 
respective extension.json
+   $wgGroupPermissions['contentadmin']['nuke'] = true;
+   $wgGroupPermissions['contentadmin']['massmessage'] = true;
+   $wgGroupPermissions['contentadmin']['spamblacklistlog'] = true;
+
$wgMessageCacheType = 'memcached-pecl';
 
if ( $wgDBname === 'labswiki' ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/382024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62e8a93760b639cdf0c60f13d117c74065030414
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: EddieGP 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits