[MediaWiki-commits] [Gerrit] operations/puppet[production]: dumps/site: remove outdated comment about firewall

2017-11-22 Thread ArielGlenn (Code Review) 
ArielGlenn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/392767 )

Change subject: dumps/site: remove outdated comment about firewall
..


dumps/site: remove outdated comment about firewall

role::dumps::public::server already includes
::profile::base::firewall so this comment is not
accurate anymore.

Change-Id: Iee15d7caf2f46ec0e86ae29df729b0926b1bf120
---
M manifests/site.pp
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  ArielGlenn: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/manifests/site.pp b/manifests/site.pp
index c1d8a57..be957b0 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1357,8 +1357,6 @@
 
 node /labstore100[67]\.wikimedia\.org/ {
 role(dumps::public::server)
-# Do not enable yet
-# include ::base::firewall
 }
 
 node /labstore200[1-2]\.codfw\.wmnet/ {

-- 
To view, visit https://gerrit.wikimedia.org/r/392767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee15d7caf2f46ec0e86ae29df729b0926b1bf120
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: ArielGlenn 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: dumps/site: remove outdated comment about firewall

2017-11-21 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392767 )

Change subject: dumps/site: remove outdated comment about firewall
..

dumps/site: remove outdated comment about firewall

role::dumps::public::server already includes
::profile::base::firewall so this comment is not
accurate anymore.

Change-Id: Iee15d7caf2f46ec0e86ae29df729b0926b1bf120
---
M manifests/site.pp
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/67/392767/1

diff --git a/manifests/site.pp b/manifests/site.pp
index f17b9b5..568c965 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1357,8 +1357,6 @@
 
 node /labstore100[67]\.wikimedia\.org/ {
 role(dumps::public::server)
-# Do not enable yet
-# include ::base::firewall
 }
 
 node /labstore200[1-2]\.codfw\.wmnet/ {

-- 
To view, visit https://gerrit.wikimedia.org/r/392767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee15d7caf2f46ec0e86ae29df729b0926b1bf120
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits