[MediaWiki-commits] [Gerrit] operations/puppet[production]: ganglia: ensure more things are gone in decom class

2017-11-28 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393707 )

Change subject: ganglia: ensure more things are gone in decom class
..


ganglia: ensure more things are gone in decom class

Bug: T177225
Change-Id: I2a0fdff42330f920838ee25132734d19a63860c4
---
M modules/ganglia/manifests/monitor/decommission.pp
1 file changed, 16 insertions(+), 1 deletion(-)

Approvals:
  Alexandros Kosiaris: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/ganglia/manifests/monitor/decommission.pp 
b/modules/ganglia/manifests/monitor/decommission.pp
index 088bed9..ca122a6 100644
--- a/modules/ganglia/manifests/monitor/decommission.pp
+++ b/modules/ganglia/manifests/monitor/decommission.pp
@@ -23,7 +23,22 @@
 force   => true,
 require => Package['ganglia-monitor'],
 }
-
+# in some cases /var/lib/ganglia becomes a remnant
+# with files like pdns_gmetric.state in it
+file { '/var/lib/ganglia/':
+ensure  => absent,
+recurse => true,
+force   => true,
+require => Package['ganglia-monitor'],
+}
+# just to make sure
+service { 'ganglia-monitor':
+ensure => 'stopped',
+}
+# in some cases the pid file was left even when service was stopped
+file { '/run/ganglia-monitor.pid':
+ensure => absent,
+}
 file { '/etc/systemd/system/ganglia-monitor.service':
 ensure => absent,
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/393707
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a0fdff42330f920838ee25132734d19a63860c4
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ganglia: ensure more things are gone in decom class

2017-11-27 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393707 )

Change subject: ganglia: ensure more things are gone in decom class
..

ganglia: ensure more things are gone in decom class

Bug: T177225
Change-Id: I2a0fdff42330f920838ee25132734d19a63860c4
---
M modules/ganglia/manifests/monitor/decommission.pp
1 file changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/07/393707/1

diff --git a/modules/ganglia/manifests/monitor/decommission.pp 
b/modules/ganglia/manifests/monitor/decommission.pp
index 088bed9..ca122a6 100644
--- a/modules/ganglia/manifests/monitor/decommission.pp
+++ b/modules/ganglia/manifests/monitor/decommission.pp
@@ -23,7 +23,22 @@
 force   => true,
 require => Package['ganglia-monitor'],
 }
-
+# in some cases /var/lib/ganglia becomes a remnant
+# with files like pdns_gmetric.state in it
+file { '/var/lib/ganglia/':
+ensure  => absent,
+recurse => true,
+force   => true,
+require => Package['ganglia-monitor'],
+}
+# just to make sure
+service { 'ganglia-monitor':
+ensure => 'stopped',
+}
+# in some cases the pid file was left even when service was stopped
+file { '/run/ganglia-monitor.pid':
+ensure => absent,
+}
 file { '/etc/systemd/system/ganglia-monitor.service':
 ensure => absent,
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/393707
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a0fdff42330f920838ee25132734d19a63860c4
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits