[MediaWiki-commits] [Gerrit] operations/puppet[production]: network::constants: add fake CACHE_MISC for labs

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/402136 )

Change subject: network::constants: add fake CACHE_MISC for labs
..


network::constants: add fake CACHE_MISC for labs

The CACHE_MISC variable doesn't exist in labs but we use it in
ferm rules all over the place now.

This means that none of the roles for services behind misc-web
can be used/tested on labs.

It will simply fail for not finding this variable.

Add it in the labs section and use
novaproxy-01.project-proxy.eqiad.wmflabs
since that is the closest thing to misc-varnish in prod.

Change-Id: I1b119c9170f9d709fb652976868e96816f6c46dc
---
M modules/network/manifests/constants.pp
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Alexandros Kosiaris: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/network/manifests/constants.pp 
b/modules/network/manifests/constants.pp
index 4be6e71..efe5506 100644
--- a/modules/network/manifests/constants.pp
+++ b/modules/network/manifests/constants.pp
@@ -217,6 +217,9 @@
 '208.80.155.120',   # 
labpuppetmaster1002.wikimedia.org
 '2620:0:861:4:208:80:155:120',  # 
labpuppetmaster1002.wikimedia.org
 ],
+'cache_misc' => [ # So that roles with CACHE_MISC in ferm rules 
can be used in labs
+'10.68.21.68', # novaproxy-01.project-proxy.eqiad.wmflabs
+],
 }
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/402136
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b119c9170f9d709fb652976868e96816f6c46dc
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Volans 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: network::constants: add fake CACHE_MISC for labs

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/402136 )

Change subject: network::constants: add fake CACHE_MISC for labs
..

network::constants: add fake CACHE_MISC for labs

The CACHE_MISC variable doesn't exist in labs but we use it in
ferm rules all over the place now.

This means that none of the roles for services behind misc-web
can be used/tested on labs.

It will simply fail for not finding this variable.

Add a fake "127.0.0.1" value to unbreak the puppet runs.

Change-Id: I1b119c9170f9d709fb652976868e96816f6c46dc
---
M modules/network/manifests/constants.pp
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/36/402136/1

diff --git a/modules/network/manifests/constants.pp 
b/modules/network/manifests/constants.pp
index 4be6e71..820a6a9 100644
--- a/modules/network/manifests/constants.pp
+++ b/modules/network/manifests/constants.pp
@@ -217,6 +217,9 @@
 '208.80.155.120',   # 
labpuppetmaster1002.wikimedia.org
 '2620:0:861:4:208:80:155:120',  # 
labpuppetmaster1002.wikimedia.org
 ],
+'cache_misc' => [ # So that roles using it can be used in wmflabs
+'127.0.0.1',
+   ],
 }
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/402136
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b119c9170f9d709fb652976868e96816f6c46dc
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits