[MediaWiki-commits] [Gerrit] operations/puppet[production]: postgresql::user: Allow password to be undefined

2017-12-14 Thread Alexandros Kosiaris (Code Review) 
Alexandros Kosiaris has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/392437 )

Change subject: postgresql::user: Allow password to be undefined
..


postgresql::user: Allow password to be undefined

Allow password to be undefined, meaning we will never set a password for
the user

Change-Id: I90a5e04859ef5c056ae8ca5bfc5a48872bc18825
---
M modules/postgresql/manifests/user.pp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Alexandros Kosiaris: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/postgresql/manifests/user.pp 
b/modules/postgresql/manifests/user.pp
index 6217a2c..2bdeae9 100644
--- a/modules/postgresql/manifests/user.pp
+++ b/modules/postgresql/manifests/user.pp
@@ -26,7 +26,7 @@
 #
 define postgresql::user(
 $user,
-$password,
+$password = undef,
 $database = 'template1',
 $type = 'host',
 $method = 'md5',
@@ -60,7 +60,7 @@
 }
 
 # This will not be run on a slave as it is read-only
-if $master {
+if $master and $password {
 $password_md5 = md5("${password}${user}")
 
 exec { "pass_set-${name}":

-- 
To view, visit https://gerrit.wikimedia.org/r/392437
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I90a5e04859ef5c056ae8ca5bfc5a48872bc18825
Gerrit-PatchSet: 5
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: postgresql::user: Allow password to be undefined

2017-11-20 Thread Alexandros Kosiaris (Code Review) 
Alexandros Kosiaris has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392437 )

Change subject: postgresql::user: Allow password to be undefined
..

postgresql::user: Allow password to be undefined

Allow password to be undefined, meaning we will never set a password for
the user

Change-Id: I90a5e04859ef5c056ae8ca5bfc5a48872bc18825
---
M modules/postgresql/manifests/user.pp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/37/392437/1

diff --git a/modules/postgresql/manifests/user.pp 
b/modules/postgresql/manifests/user.pp
index 6217a2c..2bdeae9 100644
--- a/modules/postgresql/manifests/user.pp
+++ b/modules/postgresql/manifests/user.pp
@@ -26,7 +26,7 @@
 #
 define postgresql::user(
 $user,
-$password,
+$password = undef,
 $database = 'template1',
 $type = 'host',
 $method = 'md5',
@@ -60,7 +60,7 @@
 }
 
 # This will not be run on a slave as it is read-only
-if $master {
+if $master and $password {
 $password_md5 = md5("${password}${user}")
 
 exec { "pass_set-${name}":

-- 
To view, visit https://gerrit.wikimedia.org/r/392437
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I90a5e04859ef5c056ae8ca5bfc5a48872bc18825
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits