[MediaWiki-commits] [Gerrit] operations/puppet[production]: prometheus: remove duplicate firewall include

2018-01-08 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403094 )

Change subject: prometheus: remove duplicate firewall include
..


prometheus: remove duplicate firewall include

The firewall is already included in the role classes.
Compare to prometheus eqiad.

Change-Id: Ieaab30cbcfd73fb1b83c03482b0be85d3007588c
---
M manifests/site.pp
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/manifests/site.pp b/manifests/site.pp
index 4e6abe4..4397bd6 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1820,7 +1820,6 @@
 
 node /^prometheus200[34]\.codfw\.wmnet$/ {
 role(prometheus)
-include ::base::firewall
 }
 
 node 'puppetcompiler1001.eqiad.wmnet' {

-- 
To view, visit https://gerrit.wikimedia.org/r/403094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaab30cbcfd73fb1b83c03482b0be85d3007588c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: prometheus: remove duplicate firewall include

2018-01-08 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/403094 )

Change subject: prometheus: remove duplicate firewall include
..

prometheus: remove duplicate firewall include

The firewall is already included in the role classes.
Compare to prometheus eqiad.

Change-Id: Ieaab30cbcfd73fb1b83c03482b0be85d3007588c
---
M manifests/site.pp
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/94/403094/1

diff --git a/manifests/site.pp b/manifests/site.pp
index 4e6abe4..4397bd6 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1820,7 +1820,6 @@
 
 node /^prometheus200[34]\.codfw\.wmnet$/ {
 role(prometheus)
-include ::base::firewall
 }
 
 node 'puppetcompiler1001.eqiad.wmnet' {

-- 
To view, visit https://gerrit.wikimedia.org/r/403094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieaab30cbcfd73fb1b83c03482b0be85d3007588c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits