Dzahn has submitted this change and it was merged.
Change subject: snapshot: Fix variable contains an uppercase letter
..
snapshot: Fix variable contains an uppercase letter
Bug: T93645
Change-Id: Ie32e3820da9d7f20d93a8aec67f91968902af431
---
M modules/snapshot/manifests/cron/cirrussearch.pp
M modules/snapshot/manifests/cron/contentxlation.pp
M modules/snapshot/manifests/cron/wikidatadumps/json.pp
M modules/snapshot/manifests/cron/wikidatadumps/ttl.pp
4 files changed, 15 insertions(+), 15 deletions(-)
Approvals:
ArielGlenn: Looks good to me, but someone else must approve
Dzahn: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/snapshot/manifests/cron/cirrussearch.pp
b/modules/snapshot/manifests/cron/cirrussearch.pp
index 5994ba8..6fa3476 100644
--- a/modules/snapshot/manifests/cron/cirrussearch.pp
+++ b/modules/snapshot/manifests/cron/cirrussearch.pp
@@ -16,8 +16,8 @@
source => 'puppet:///modules/snapshot/cron/logrotate.cirrusdump',
}
-$scriptPath = '/usr/local/bin/dumpcirrussearch.sh'
-file { $scriptPath:
+$scriptpath = '/usr/local/bin/dumpcirrussearch.sh'
+file { $scriptpath:
mode=> '0755',
owner => 'root',
group => 'root',
@@ -26,13 +26,13 @@
cron { 'cirrussearch-dump':
ensure => 'present',
-command => "${scriptPath} --config ${confsdir}/wikidump.conf",
+command => "${scriptpath} --config ${confsdir}/wikidump.conf",
environment => 'MAILTO=ops-du...@wikimedia.org',
user=> $user,
minute => '15',
hour=> '16',
weekday => '1',
-require => File[$scriptPath],
+require => File[$scriptpath],
}
}
diff --git a/modules/snapshot/manifests/cron/contentxlation.pp
b/modules/snapshot/manifests/cron/contentxlation.pp
index 00f53a5..a821146 100644
--- a/modules/snapshot/manifests/cron/contentxlation.pp
+++ b/modules/snapshot/manifests/cron/contentxlation.pp
@@ -8,8 +8,8 @@
$confsdir = $snapshot::dumps::dirs::confsdir
$xlationdir = "${otherdir}/contenttranslation"
-$scriptPath = '/usr/local/bin/dumpcontentxlation.sh'
-file { $scriptPath:
+$scriptpath = '/usr/local/bin/dumpcontentxlation.sh'
+file { $scriptpath:
mode=> '0755',
owner => 'root',
group => 'root',
@@ -33,6 +33,6 @@
minute => '10',
hour=> '9',
weekday => '5',
-require => File[$scriptPath],
+require => File[$scriptpath],
}
}
diff --git a/modules/snapshot/manifests/cron/wikidatadumps/json.pp
b/modules/snapshot/manifests/cron/wikidatadumps/json.pp
index 4618213..60f7b30 100644
--- a/modules/snapshot/manifests/cron/wikidatadumps/json.pp
+++ b/modules/snapshot/manifests/cron/wikidatadumps/json.pp
@@ -3,8 +3,8 @@
) {
include snapshot::cron::wikidatadumps::common
-$scriptPath = '/usr/local/bin/dumpwikidatajson.sh'
-file { $scriptPath:
+$scriptpath = '/usr/local/bin/dumpwikidatajson.sh'
+file { $scriptpath:
mode=> '0755',
owner => 'root',
group => 'root',
@@ -14,12 +14,12 @@
cron { 'wikidatajson-dump':
ensure => 'present',
-command => $scriptPath,
+command => $scriptpath,
user=> $user,
minute => '15',
hour=> '3',
weekday => '1',
-require => File[$scriptPath],
+require => File[$scriptpath],
}
}
diff --git a/modules/snapshot/manifests/cron/wikidatadumps/ttl.pp
b/modules/snapshot/manifests/cron/wikidatadumps/ttl.pp
index ce71051..e90c835 100644
--- a/modules/snapshot/manifests/cron/wikidatadumps/ttl.pp
+++ b/modules/snapshot/manifests/cron/wikidatadumps/ttl.pp
@@ -3,8 +3,8 @@
) {
include snapshot::cron::wikidatadumps::common
-$scriptPath = '/usr/local/bin/dumpwikidatattl.sh'
-file { $scriptPath:
+$scriptpath = '/usr/local/bin/dumpwikidatattl.sh'
+file { $scriptpath:
mode=> '0755',
owner => 'root',
group => 'root',
@@ -14,12 +14,12 @@
cron { 'wikidatattl-dump':
ensure => 'present',
-command => $scriptPath,
+command => $scriptpath,
user=> $user,
minute => '0',
hour=> '23',
weekday => '1',
-require => File[$scriptPath],
+require => File[$scriptpath],
}
}
--
To view, visit https://gerrit.wikimedia.org/r/308355
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie32e3820da9d7f20d93a8aec67f91968902af431
Gerrit-PatchSet: 5
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox
Gerrit-Reviewer: ArielGlenn
Gerrit-Reviewer: Dzahn
Gerrit-Reviewer: EBernhardson