[MediaWiki-commits] [Gerrit] operations/puppet[production]: Quote "owner" and "group" attributes for file and git::clone...

2016-12-05 Thread Alexandros Kosiaris (Code Review) 
Alexandros Kosiaris has submitted this change and it was merged.

Change subject: Quote "owner" and "group" attributes for file and git::clone 
resources
..


Quote "owner" and "group" attributes for file and git::clone resources

Change-Id: Ic4ba4ae1ea2103b5172f87be8784d6239a1fd803
---
M modules/bacula/manifests/director.pp
M modules/bacula/manifests/director/catalog.pp
M modules/bacula/manifests/director/fileset.pp
M modules/bacula/manifests/director/pool.pp
M modules/bacula/manifests/director/schedule.pp
M modules/base/manifests/service_unit.pp
M modules/confd/manifests/init.pp
M modules/conftool/manifests/init.pp
M modules/conftool/manifests/master.pp
M modules/drac/manifests/init.pp
M modules/elasticsearch/manifests/ganglia.pp
M modules/etcd/manifests/client/globalconfig.pp
M modules/java/manifests/tools.pp
M modules/labstore/manifests/nfs_mount.pp
M modules/lshell/manifests/init.pp
M modules/lvs/manifests/balancer/runcommand.pp
M modules/miredo/manifests/init.pp
M modules/mongodb/manifests/init.pp
M modules/ntp/manifests/daemon.pp
M modules/openstack/manifests/ceilometer/compute.pp
M modules/openstack/manifests/ceilometer/controller.pp
M modules/openstack/manifests/designate/service.pp
M modules/openstack/manifests/glance/service.pp
M modules/openstack/manifests/keystone/service.pp
M modules/phabricator/manifests/mailrelay.pp
M modules/pivot/manifests/init.pp
M modules/role/manifests/cache/base.pp
M modules/role/manifests/zuul/server.pp
M modules/snapshot/manifests/cron/dumplists.pp
M modules/snapshot/manifests/cron/mediaperprojectlists.pp
M modules/snapshot/manifests/dumps/cron.pp
M modules/systemd/manifests/sidekick.pp
M modules/tlsproxy/manifests/instance.pp
M modules/yubiauth/manifests/yhsm_daemon.pp
M modules/yubiauth/manifests/yhsm_yubikey_ksm.pp
35 files changed, 100 insertions(+), 100 deletions(-)

Approvals:
  Alexandros Kosiaris: Verified; Looks good to me, approved



diff --git a/modules/bacula/manifests/director.pp 
b/modules/bacula/manifests/director.pp
index dfbbe76..b30c3b6 100644
--- a/modules/bacula/manifests/director.pp
+++ b/modules/bacula/manifests/director.pp
@@ -65,8 +65,8 @@
 
 file { '/etc/bacula/bacula-dir.conf':
 ensure  => present,
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 mode=> '0440',
 notify  => Service['bacula-director'],
 content => template('bacula/bacula-dir.conf.erb'),
@@ -80,8 +80,8 @@
 force   => true,
 purge   => true,
 mode=> '0444',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 require => Package["bacula-director-${sqlvariant}"],
 }
 
@@ -92,8 +92,8 @@
 force   => true,
 purge   => true,
 mode=> '0444',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 require => Package["bacula-director-${sqlvariant}"],
 }
 
@@ -103,8 +103,8 @@
 force   => true,
 purge   => true,
 mode=> '0444',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 require => Package["bacula-director-${sqlvariant}"],
 }
 
@@ -112,8 +112,8 @@
 file { '/etc/bacula/jobs.d/restore-migrate-jobs.conf':
 ensure  => file,
 mode=> '0444',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 require => File['/etc/bacula/jobs.d'],
 content => template('bacula/restore-migrate-jobs.conf.erb'),
 }
@@ -125,8 +125,8 @@
 force   => true,
 purge   => true,
 mode=> '0444',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 require => Package["bacula-director-${sqlvariant}"],
 }
 
@@ -134,8 +134,8 @@
 @@file { '/etc/bacula/bconsole.conf':
 ensure  => present,
 mode=> '0440',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 content => template('bacula/bconsole.conf.erb'),
 tag => "bacula-console-${::fqdn}",
 }
diff --git a/modules/bacula/manifests/director/catalog.pp 
b/modules/bacula/manifests/director/catalog.pp
index ce7724b..099ff6d 100644
--- a/modules/bacula/manifests/director/catalog.pp
+++ b/modules/bacula/manifests/director/catalog.pp
@@ -24,8 +24,8 @@
 define bacula::director::catalog($dbname, $dbuser, $dbhost, $dbport, 
$dbpassword) {
 file { "/etc/bacula/conf.d/catalog-${name}.conf":
 ensure  => present,
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 mode=> '0440',
 content => template('bacula/bacula-dir-catalog.e

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Quote "owner" and "group" attributes for file and git::clone...

2016-12-03 Thread Tim Landscheidt (Code Review) 
Tim Landscheidt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/325146

Change subject: Quote "owner" and "group" attributes for file and git::clone 
resources
..

Quote "owner" and "group" attributes for file and git::clone resources

Change-Id: Ic4ba4ae1ea2103b5172f87be8784d6239a1fd803
---
M modules/bacula/manifests/director.pp
M modules/bacula/manifests/director/catalog.pp
M modules/bacula/manifests/director/fileset.pp
M modules/bacula/manifests/director/pool.pp
M modules/bacula/manifests/director/schedule.pp
M modules/base/manifests/service_unit.pp
M modules/confd/manifests/init.pp
M modules/conftool/manifests/init.pp
M modules/conftool/manifests/master.pp
M modules/drac/manifests/init.pp
M modules/elasticsearch/manifests/ganglia.pp
M modules/etcd/manifests/client/globalconfig.pp
M modules/java/manifests/tools.pp
M modules/labstore/manifests/nfs_mount.pp
M modules/lshell/manifests/init.pp
M modules/lvs/manifests/balancer/runcommand.pp
M modules/miredo/manifests/init.pp
M modules/mongodb/manifests/init.pp
M modules/ntp/manifests/daemon.pp
M modules/openstack/manifests/ceilometer/compute.pp
M modules/openstack/manifests/ceilometer/controller.pp
M modules/openstack/manifests/designate/service.pp
M modules/openstack/manifests/glance/service.pp
M modules/openstack/manifests/keystone/service.pp
M modules/phabricator/manifests/mailrelay.pp
M modules/pivot/manifests/init.pp
M modules/role/manifests/cache/base.pp
M modules/role/manifests/zuul/server.pp
M modules/snapshot/manifests/cron/dumplists.pp
M modules/snapshot/manifests/cron/mediaperprojectlists.pp
M modules/snapshot/manifests/dumps/cron.pp
M modules/systemd/manifests/sidekick.pp
M modules/tlsproxy/manifests/instance.pp
M modules/yubiauth/manifests/yhsm_daemon.pp
M modules/yubiauth/manifests/yhsm_yubikey_ksm.pp
35 files changed, 100 insertions(+), 100 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/46/325146/1

diff --git a/modules/bacula/manifests/director.pp 
b/modules/bacula/manifests/director.pp
index dfbbe76..b30c3b6 100644
--- a/modules/bacula/manifests/director.pp
+++ b/modules/bacula/manifests/director.pp
@@ -65,8 +65,8 @@
 
 file { '/etc/bacula/bacula-dir.conf':
 ensure  => present,
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 mode=> '0440',
 notify  => Service['bacula-director'],
 content => template('bacula/bacula-dir.conf.erb'),
@@ -80,8 +80,8 @@
 force   => true,
 purge   => true,
 mode=> '0444',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 require => Package["bacula-director-${sqlvariant}"],
 }
 
@@ -92,8 +92,8 @@
 force   => true,
 purge   => true,
 mode=> '0444',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 require => Package["bacula-director-${sqlvariant}"],
 }
 
@@ -103,8 +103,8 @@
 force   => true,
 purge   => true,
 mode=> '0444',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 require => Package["bacula-director-${sqlvariant}"],
 }
 
@@ -112,8 +112,8 @@
 file { '/etc/bacula/jobs.d/restore-migrate-jobs.conf':
 ensure  => file,
 mode=> '0444',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 require => File['/etc/bacula/jobs.d'],
 content => template('bacula/restore-migrate-jobs.conf.erb'),
 }
@@ -125,8 +125,8 @@
 force   => true,
 purge   => true,
 mode=> '0444',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 require => Package["bacula-director-${sqlvariant}"],
 }
 
@@ -134,8 +134,8 @@
 @@file { '/etc/bacula/bconsole.conf':
 ensure  => present,
 mode=> '0440',
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 content => template('bacula/bconsole.conf.erb'),
 tag => "bacula-console-${::fqdn}",
 }
diff --git a/modules/bacula/manifests/director/catalog.pp 
b/modules/bacula/manifests/director/catalog.pp
index ce7724b..099ff6d 100644
--- a/modules/bacula/manifests/director/catalog.pp
+++ b/modules/bacula/manifests/director/catalog.pp
@@ -24,8 +24,8 @@
 define bacula::director::catalog($dbname, $dbuser, $dbhost, $dbport, 
$dbpassword) {
 file { "/etc/bacula/conf.d/catalog-${name}.conf":
 ensure  => present,
-owner   => root,
-group   => bacula,
+owner   => 'root',
+group   => 'bacula',
 mode=> '0440',
 con