[MediaWiki-commits] [Gerrit] operations/puppet[production]: Tools: Do not install adminbot

2017-02-08 Thread Rush (Code Review)
Rush has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/336351 )

Change subject: Tools: Do not install adminbot
..


Tools: Do not install adminbot

The package adminbot was used exclusively by the tool morebots which
has been replaced by the tool stashbot.

Bug: T157400
Change-Id: I8c875b5a027f9155edccb351befe2ca4701154f9
---
M modules/toollabs/manifests/exec_environ.pp
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Rush: Looks good to me, approved
  BryanDavis: Looks good to me, but someone else must approve
  jenkins-bot: Verified

Objections:
  Tim Landscheidt: There's a problem with this change, please improve



diff --git a/modules/toollabs/manifests/exec_environ.pp 
b/modules/toollabs/manifests/exec_environ.pp
index 649ce59..1a7ed79 100644
--- a/modules/toollabs/manifests/exec_environ.pp
+++ b/modules/toollabs/manifests/exec_environ.pp
@@ -238,7 +238,6 @@
 'tesseract-ocr-vie',
 
 # Other packages
-'adminbot',
 'bison',   # T67974.
 'calibre', # T100165
 'csh', # common user request

-- 
To view, visit https://gerrit.wikimedia.org/r/336351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c875b5a027f9155edccb351befe2ca4701154f9
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Coren 
Gerrit-Reviewer: Madhuvishy 
Gerrit-Reviewer: Merlijn van Deen 
Gerrit-Reviewer: Rush 
Gerrit-Reviewer: Tim Landscheidt 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] operations/puppet[production]: Tools: Do not install adminbot

2017-02-06 Thread Tim Landscheidt (Code Review)
Tim Landscheidt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/336351 )

Change subject: Tools: Do not install adminbot
..

Tools: Do not install adminbot

The package adminbot was used exclusively by the tool morebots which
has been replaced by the tool stashbot.

Bug: T157400
Change-Id: I8c875b5a027f9155edccb351befe2ca4701154f9
---
M modules/toollabs/manifests/exec_environ.pp
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/51/336351/1

diff --git a/modules/toollabs/manifests/exec_environ.pp 
b/modules/toollabs/manifests/exec_environ.pp
index 2082338..2e48512 100644
--- a/modules/toollabs/manifests/exec_environ.pp
+++ b/modules/toollabs/manifests/exec_environ.pp
@@ -238,7 +238,6 @@
 'tesseract-ocr-vie',
 
 # Other packages
-'adminbot',
 'bison',   # T67974.
 'calibre', # T100165
 'csh', # common user request

-- 
To view, visit https://gerrit.wikimedia.org/r/336351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c875b5a027f9155edccb351befe2ca4701154f9
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits