[MediaWiki-commits] [Gerrit] operations/puppet[production]: Tools: Remove bashisms from clush

[Yuvipanda (Code Review)]

Yuvipanda has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/326379 )

Change subject: Tools: Remove bashisms from clush
..


Tools: Remove bashisms from clush

Change-Id: Ia2da9869a78128fcf155fe6350b8d86524469398
---
M modules/role/files/toollabs/clush/clush
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yuvipanda: Verified; Looks good to me, approved



diff --git a/modules/role/files/toollabs/clush/clush 
b/modules/role/files/toollabs/clush/clush
index 8ef..a0f3e1b 100644
--- a/modules/role/files/toollabs/clush/clush
+++ b/modules/role/files/toollabs/clush/clush
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 # Wrapper script around clush to add some additional features
 #  - Make sure it is *not* being called by someone as root.
 #We do not want people to be using it directly interactively as
@@ -9,7 +9,7 @@
 
 CALLINGUSER="$(whoami)"
 
-if [[ $CALLINGUSER == "root" ]]; then
+if [ "$CALLINGUSER" = root ]; then
 echo "Only members of tools.admin group can use clush interactively"
 echo "This is to make sure we have a nice and clean audit trail"
 echo "Do not run this directly as root or use sudo"

-- 
To view, visit https://gerrit.wikimedia.org/r/326379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2da9869a78128fcf155fe6350b8d86524469398
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Tools: Remove bashisms from clush

[Tim Landscheidt (Code Review)]

Tim Landscheidt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/326379 )

Change subject: Tools: Remove bashisms from clush
..

Tools: Remove bashisms from clush

Change-Id: Ia2da9869a78128fcf155fe6350b8d86524469398
---
M modules/role/files/toollabs/clush/clush
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/79/326379/1

diff --git a/modules/role/files/toollabs/clush/clush 
b/modules/role/files/toollabs/clush/clush
index 8ef..a0f3e1b 100644
--- a/modules/role/files/toollabs/clush/clush
+++ b/modules/role/files/toollabs/clush/clush
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 # Wrapper script around clush to add some additional features
 #  - Make sure it is *not* being called by someone as root.
 #We do not want people to be using it directly interactively as
@@ -9,7 +9,7 @@
 
 CALLINGUSER="$(whoami)"
 
-if [[ $CALLINGUSER == "root" ]]; then
+if [ "$CALLINGUSER" = root ]; then
 echo "Only members of tools.admin group can use clush interactively"
 echo "This is to make sure we have a nice and clean audit trail"
 echo "Do not run this directly as root or use sudo"

-- 
To view, visit https://gerrit.wikimedia.org/r/326379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2da9869a78128fcf155fe6350b8d86524469398
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits