[MediaWiki-commits] [Gerrit] operations/puppet[production]: apache: fix 42 x 'class not documented', add doc links

2016-09-15 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged.

Change subject: apache: fix 42 x 'class not documented', add doc links
..


apache: fix 42 x 'class not documented', add doc links

Fixes 42 lint warnings about classes not being documented,
by linking to the relevant docs page for each Apache module.

Bug: T127797
Change-Id: Ib552f24bd3e4ee80b92cb0a32b089452fd2a4b1c
---
M modules/apache/manifests/mod.pp
1 file changed, 91 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/apache/manifests/mod.pp b/modules/apache/manifests/mod.pp
index ff85c1b..633938a 100644
--- a/modules/apache/manifests/mod.pp
+++ b/modules/apache/manifests/mod.pp
@@ -9,57 +9,148 @@
 # Modules that are bundled with the apache2 package
 # lint:ignore:autoloader_layout
 # ^ FIXABLE ?
+
+# https://httpd.apache.org/docs/current/mod/mod_actions.html
 class apache::mod::actions { apache::mod_conf { 'actions':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_alias.html
 class apache::mod::alias   { apache::mod_conf { 'alias':  } }
+
+# https://httpd.apache.org/docs/current/mod/mod_auth_basic.html
 class apache::mod::auth_basic  { apache::mod_conf { 'auth_basic': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_authn_file.html
 class apache::mod::authn_file  { apache::mod_conf { 'authn_file': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_authz_groupfile.html
 class apache::mod::authz_groupfile { apache::mod_conf { 'authz_groupfile': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_authz_host.html
 class apache::mod::authz_host  { apache::mod_conf { 'authz_host': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_authnz_ldap.html
 class apache::mod::authnz_ldap { apache::mod_conf { 'authnz_ldap':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_authz_user.html
 class apache::mod::authz_user  { apache::mod_conf { 'authz_user': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_autoindex.html
 class apache::mod::autoindex   { apache::mod_conf { 'autoindex':  } }
+
+# https://httpd.apache.org/docs/current/mod/mod_cgi.html
 class apache::mod::cgi { apache::mod_conf { 'cgi':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_dav.html
 class apache::mod::dav { apache::mod_conf { 'dav':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_dav_fs.html
 class apache::mod::dav_fs  { apache::mod_conf { 'dav_fs': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_dir.html
 class apache::mod::dir { apache::mod_conf { 'dir':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_env.html
 class apache::mod::env { apache::mod_conf { 'env':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_expires.html
 class apache::mod::expires { apache::mod_conf { 'expires':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_filter.html
 class apache::mod::filter  { apache::mod_conf { 'filter': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_headers.html
 class apache::mod::headers { apache::mod_conf { 'headers':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_mime.html
 class apache::mod::mime{ apache::mod_conf { 'mime':   } }
+
+# https://httpd.apache.org/docs/current/mod/mod_negotiation.html
 class apache::mod::negotiation { apache::mod_conf { 'negotiation':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_proxy.html
 class apache::mod::proxy   { apache::mod_conf { 'proxy':  } }
+
+# https://httpd.apache.org/docs/current/mod/mod_proxy_balancer.html
 class apache::mod::proxy_balancer  { apache::mod_conf { 'proxy_balancer': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_proxy_http.html
 class apache::mod::proxy_http  { apache::mod_conf { 'proxy_http': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_authz_user.html
 class apache::mod::rewrite { apache::mod_conf { 'rewrite':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_setenvif.html
 class apache::mod::setenvif{ apache::mod_conf { 'setenvif':   } }
+
+# https://httpd.apache.org/docs/current/mod/mod_ssl.html
 class apache::mod::ssl { apache::mod_conf { 'ssl':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_substitute.html
 class apache::mod::substitute  { apache::mod_conf { 'substitute': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_userdir.html
 class apache::mod::userdir { apache::mod_conf { 'userdir':} }
+
 # lint:endignore
 
 # Modules that depend on additional packages
 # lint:ignore:right_to_left_relationship lint:ignore:autoloader_layout
 # FIXABLE ^ ?
+
+#

[MediaWiki-commits] [Gerrit] operations/puppet[production]: apache: fix 42 x 'class not documented', add doc links

2016-09-14 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/310717

Change subject: apache: fix 42 x 'class not documented', add doc links
..

apache: fix 42 x 'class not documented', add doc links

Fixes 42 lint warnings about classes not being documented,
by linking to the relevant docs page for each Apache module.

Bug: T127797
Change-Id: Ib552f24bd3e4ee80b92cb0a32b089452fd2a4b1c
---
M modules/apache/manifests/mod.pp
1 file changed, 91 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/17/310717/1

diff --git a/modules/apache/manifests/mod.pp b/modules/apache/manifests/mod.pp
index ff85c1b..633938a 100644
--- a/modules/apache/manifests/mod.pp
+++ b/modules/apache/manifests/mod.pp
@@ -9,57 +9,148 @@
 # Modules that are bundled with the apache2 package
 # lint:ignore:autoloader_layout
 # ^ FIXABLE ?
+
+# https://httpd.apache.org/docs/current/mod/mod_actions.html
 class apache::mod::actions { apache::mod_conf { 'actions':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_alias.html
 class apache::mod::alias   { apache::mod_conf { 'alias':  } }
+
+# https://httpd.apache.org/docs/current/mod/mod_auth_basic.html
 class apache::mod::auth_basic  { apache::mod_conf { 'auth_basic': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_authn_file.html
 class apache::mod::authn_file  { apache::mod_conf { 'authn_file': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_authz_groupfile.html
 class apache::mod::authz_groupfile { apache::mod_conf { 'authz_groupfile': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_authz_host.html
 class apache::mod::authz_host  { apache::mod_conf { 'authz_host': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_authnz_ldap.html
 class apache::mod::authnz_ldap { apache::mod_conf { 'authnz_ldap':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_authz_user.html
 class apache::mod::authz_user  { apache::mod_conf { 'authz_user': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_autoindex.html
 class apache::mod::autoindex   { apache::mod_conf { 'autoindex':  } }
+
+# https://httpd.apache.org/docs/current/mod/mod_cgi.html
 class apache::mod::cgi { apache::mod_conf { 'cgi':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_dav.html
 class apache::mod::dav { apache::mod_conf { 'dav':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_dav_fs.html
 class apache::mod::dav_fs  { apache::mod_conf { 'dav_fs': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_dir.html
 class apache::mod::dir { apache::mod_conf { 'dir':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_env.html
 class apache::mod::env { apache::mod_conf { 'env':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_expires.html
 class apache::mod::expires { apache::mod_conf { 'expires':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_filter.html
 class apache::mod::filter  { apache::mod_conf { 'filter': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_headers.html
 class apache::mod::headers { apache::mod_conf { 'headers':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_mime.html
 class apache::mod::mime{ apache::mod_conf { 'mime':   } }
+
+# https://httpd.apache.org/docs/current/mod/mod_negotiation.html
 class apache::mod::negotiation { apache::mod_conf { 'negotiation':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_proxy.html
 class apache::mod::proxy   { apache::mod_conf { 'proxy':  } }
+
+# https://httpd.apache.org/docs/current/mod/mod_proxy_balancer.html
 class apache::mod::proxy_balancer  { apache::mod_conf { 'proxy_balancer': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_proxy_http.html
 class apache::mod::proxy_http  { apache::mod_conf { 'proxy_http': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_authz_user.html
 class apache::mod::rewrite { apache::mod_conf { 'rewrite':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_setenvif.html
 class apache::mod::setenvif{ apache::mod_conf { 'setenvif':   } }
+
+# https://httpd.apache.org/docs/current/mod/mod_ssl.html
 class apache::mod::ssl { apache::mod_conf { 'ssl':} }
+
+# https://httpd.apache.org/docs/current/mod/mod_substitute.html
 class apache::mod::substitute  { apache::mod_conf { 'substitute': } }
+
+# https://httpd.apache.org/docs/current/mod/mod_userdir.html
 class apache::mod::userdir { apache::mod_conf { 'userdir':} }
+
 # lint:endignore
 
 # Modules that depend on additional packages
 # lint:ignore:right_to_left_relationship lint:ignore:autoloader_layout
 # FIXABLE ^ ?
+
+#