[MediaWiki-commits] [Gerrit] operations/puppet[production]: hhvm: fix hhvm-needs-restart logic for memory

[Filippo Giunchedi (Code Review)]

Filippo Giunchedi has submitted this change and it was merged.

Change subject: hhvm: fix hhvm-needs-restart logic for memory
..


hhvm: fix hhvm-needs-restart logic for memory

Discovered during investigation for T151702, propagate exit status for
memory when restart needs to happen.

Bug: T151702
Change-Id: I8d60d04384f7719880b868e04b947b85dbf06f5d
---
M modules/hhvm/files/hhvm-needs-restart.sh
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Filippo Giunchedi: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/hhvm/files/hhvm-needs-restart.sh 
b/modules/hhvm/files/hhvm-needs-restart.sh
index cc9f062..877e238 100755
--- a/modules/hhvm/files/hhvm-needs-restart.sh
+++ b/modules/hhvm/files/hhvm-needs-restart.sh
@@ -69,7 +69,9 @@
 print "HHVM needs restart: using " sum "% of available memory";
 exit 0;
   }
-}'
+  exit 1;
+}' && exit 0
+
 
 # Queue size
 # If not defined, just exit as if everything is fine

-- 
To view, visit https://gerrit.wikimedia.org/r/323887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d60d04384f7719880b868e04b947b85dbf06f5d
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi 
Gerrit-Reviewer: Elukey 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Volans 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: hhvm: fix hhvm-needs-restart logic for memory

[Filippo Giunchedi (Code Review)]

Filippo Giunchedi has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/323887

Change subject: hhvm: fix hhvm-needs-restart logic for memory
..

hhvm: fix hhvm-needs-restart logic for memory

Discovered during investigation for T151702, propagate exit status for
memory when restart needs to happen.

Bug: T151702
Change-Id: I8d60d04384f7719880b868e04b947b85dbf06f5d
---
M modules/hhvm/files/hhvm-needs-restart.sh
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/87/323887/1

diff --git a/modules/hhvm/files/hhvm-needs-restart.sh 
b/modules/hhvm/files/hhvm-needs-restart.sh
index cc9f062..877e238 100755
--- a/modules/hhvm/files/hhvm-needs-restart.sh
+++ b/modules/hhvm/files/hhvm-needs-restart.sh
@@ -69,7 +69,9 @@
 print "HHVM needs restart: using " sum "% of available memory";
 exit 0;
   }
-}'
+  exit 1;
+}' && exit 0
+
 
 # Queue size
 # If not defined, just exit as if everything is fine

-- 
To view, visit https://gerrit.wikimedia.org/r/323887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d60d04384f7719880b868e04b947b85dbf06f5d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits