[MediaWiki-commits] [Gerrit] operations/puppet[production]: wmflib: use string for parameter of package, not symbol

2017-12-14 Thread Volans (Code Review) 
Volans has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395695 )

Change subject: wmflib: use string for parameter of package, not symbol
..


wmflib: use string for parameter of package, not symbol

In the stricter puppet version 4, the use of a symbol raises a log line;
let's get rid of those.

Change-Id: Ifd1e66e3fcc115401c0de104328d896658e72dfb
---
M modules/wmflib/lib/puppet/parser/functions/require_package.rb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Giuseppe Lavagetto: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/wmflib/lib/puppet/parser/functions/require_package.rb 
b/modules/wmflib/lib/puppet/parser/functions/require_package.rb
index dacf820..4e01e28 100644
--- a/modules/wmflib/lib/puppet/parser/functions/require_package.rb
+++ b/modules/wmflib/lib/puppet/parser/functions/require_package.rb
@@ -45,7 +45,7 @@
   begin
 host_scope = compiler.topscope.class_scope(host)
 host_scope.call_function(:create_resources,
- ['package', { package_name => { :ensure => 
:present } }])
+ ['package', { package_name => { :ensure => 
'present' } }])
   rescue Puppet::Resource::Catalog::DuplicateResourceError
   end
 

-- 
To view, visit https://gerrit.wikimedia.org/r/395695
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd1e66e3fcc115401c0de104328d896658e72dfb
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Volans 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: wmflib: use string for parameter of package, not symbol

2017-12-05 Thread Giuseppe Lavagetto (Code Review) 
Giuseppe Lavagetto has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395695 )

Change subject: wmflib: use string for parameter of package, not symbol
..

wmflib: use string for parameter of package, not symbol

In the stricter puppet version 4, the use of a symbol raises a log line;
let's get rid of those.

Change-Id: Ifd1e66e3fcc115401c0de104328d896658e72dfb
---
M modules/wmflib/lib/puppet/parser/functions/require_package.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/95/395695/1

diff --git a/modules/wmflib/lib/puppet/parser/functions/require_package.rb 
b/modules/wmflib/lib/puppet/parser/functions/require_package.rb
index dacf820..4e01e28 100644
--- a/modules/wmflib/lib/puppet/parser/functions/require_package.rb
+++ b/modules/wmflib/lib/puppet/parser/functions/require_package.rb
@@ -45,7 +45,7 @@
   begin
 host_scope = compiler.topscope.class_scope(host)
 host_scope.call_function(:create_resources,
- ['package', { package_name => { :ensure => 
:present } }])
+ ['package', { package_name => { :ensure => 
'present' } }])
   rescue Puppet::Resource::Catalog::DuplicateResourceError
   end
 

-- 
To view, visit https://gerrit.wikimedia.org/r/395695
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd1e66e3fcc115401c0de104328d896658e72dfb
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits