[MediaWiki-commits] [Gerrit] puppet-lint: enable quoted_booleans-check - change (operations/puppet)

2015-10-02 Thread Andrew Bogott (Code Review)
Andrew Bogott has submitted this change and it was merged.

Change subject: puppet-lint: enable quoted_booleans-check
..


puppet-lint: enable quoted_booleans-check

Because mixing quoted booleans and unquoted ones are a source of
confusion and nasty errors.

Bug: T113783
Change-Id: Ia783c5fc0c8314809065f0fcb2412e1b66f42f86
---
M .puppet-lint.rc
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.puppet-lint.rc b/.puppet-lint.rc
index 548eaf2..b4a99f8 100644
--- a/.puppet-lint.rc
+++ b/.puppet-lint.rc
@@ -17,9 +17,6 @@
 --no-unquoted_resource_title-check
 --no-arrow_alignment-check
 
-# "true" and "false" are everywhere.
---no-quoted_booleans-check
-
 # We dont have much documentation yet:
 --no-documentation-check
 

-- 
To view, visit https://gerrit.wikimedia.org/r/24
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia783c5fc0c8314809065f0fcb2412e1b66f42f86
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] puppet-lint: enable quoted_booleans-check - change (operations/puppet)

2015-09-25 Thread Hashar (Code Review)
Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/24

Change subject: puppet-lint: enable quoted_booleans-check
..

puppet-lint: enable quoted_booleans-check

Because mixing quoted booleans and unquoted ones are a source of
confusion and nasty errors.

Bug: T113783
Change-Id: Ia783c5fc0c8314809065f0fcb2412e1b66f42f86
---
M .puppet-lint.rc
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/11/24/1

diff --git a/.puppet-lint.rc b/.puppet-lint.rc
index 548eaf2..b4a99f8 100644
--- a/.puppet-lint.rc
+++ b/.puppet-lint.rc
@@ -17,9 +17,6 @@
 --no-unquoted_resource_title-check
 --no-arrow_alignment-check
 
-# "true" and "false" are everywhere.
---no-quoted_booleans-check
-
 # We dont have much documentation yet:
 --no-documentation-check
 

-- 
To view, visit https://gerrit.wikimedia.org/r/24
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia783c5fc0c8314809065f0fcb2412e1b66f42f86
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits