[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [Bugfix] Touch the page, not the item in newitem.py

2017-12-16 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/389426 )

Change subject: [Bugfix] Touch the page, not the item in newitem.py
..


[Bugfix] Touch the page, not the item in newitem.py

Bug: T179924
Change-Id: Id0f7dccfcf25c9278957ba27fcd3fd1cf4c381b5
---
M scripts/newitem.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Dalba: Looks good to me, approved
  jenkins-bot: Verified
  Zoranzoki21: Looks good to me, but someone else must approve



diff --git a/scripts/newitem.py b/scripts/newitem.py
index 3ebb54d..50a06f1 100755
--- a/scripts/newitem.py
+++ b/scripts/newitem.py
@@ -116,7 +116,8 @@
 "Haven't implemented that yet so skipping.")
 return
 
-self.create_item_for_page(page, callback=self._callback)
+self.create_item_for_page(
+page, callback=lambda _, exc: self._callback(page, exc))
 
 
 def main(*args):

-- 
To view, visit https://gerrit.wikimedia.org/r/389426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0f7dccfcf25c9278957ba27fcd3fd1cf4c381b5
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek 
Gerrit-Reviewer: Dalba 
Gerrit-Reviewer: Framawiki 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Magul 
Gerrit-Reviewer: Matěj Suchánek 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [Bugfix] Touch the page, not the item in newitem.py

2017-11-06 Thread Code Review
Matěj Suchánek has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/389426 )

Change subject: [Bugfix] Touch the page, not the item in newitem.py
..

[Bugfix] Touch the page, not the item in newitem.py

Change-Id: Id0f7dccfcf25c9278957ba27fcd3fd1cf4c381b5
---
M scripts/newitem.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/26/389426/1

diff --git a/scripts/newitem.py b/scripts/newitem.py
index 3ebb54d..50a06f1 100755
--- a/scripts/newitem.py
+++ b/scripts/newitem.py
@@ -116,7 +116,8 @@
 "Haven't implemented that yet so skipping.")
 return
 
-self.create_item_for_page(page, callback=self._callback)
+self.create_item_for_page(
+page, callback=lambda _, exc: self._callback(page, exc))
 
 
 def main(*args):

-- 
To view, visit https://gerrit.wikimedia.org/r/389426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0f7dccfcf25c9278957ba27fcd3fd1cf4c381b5
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits