[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [TEST] Add tests for User class

2018-01-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/401408 )

Change subject: [TEST] Add tests for User class
..


[TEST] Add tests for User class

Bug: T60941
Change-Id: I998822b88794a4e50783bc636729f0d23c88025c
---
M tests/user_tests.py
1 file changed, 22 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Xqt: Looks good to me, approved



diff --git a/tests/user_tests.py b/tests/user_tests.py
index e8678f6..7ba2dd9 100644
--- a/tests/user_tests.py
+++ b/tests/user_tests.py
@@ -36,6 +36,27 @@
 self.assertTrue(user.isEmailable())
 self.assertEqual(user.gender(), 'unknown')
 self.assertIn('userid', user.getprops())
+self.assertEqual(user.getprops()['userid'], 287832)
+self.assertEqual(user.pageid, 6927779)
+self.assertEqual(user.getUserPage(),
+ pywikibot.Page(self.site, 'Benutzer:Xqt'))
+self.assertEqual(user.getUserPage(subpage='pwb'),
+ pywikibot.Page(self.site, 'Benutzer:Xqt/pwb'))
+self.assertEqual(user.getUserTalkPage(),
+ pywikibot.Page(self.site, 'Benutzer Diskussion:Xqt'))
+self.assertEqual(user.getUserTalkPage(subpage='pwb'),
+ pywikibot.Page(self.site,
+'Benutzer Diskussion:Xqt/pwb'))
+self.assertTrue(user.is_thankable)
+contribs = user.contributions(total=10)
+self.assertEqual(len(list(contribs)), 10)
+self.assertTrue(all(isinstance(contrib, tuple)
+for contrib in contribs))
+self.assertTrue(all('user' in contrib
+and contrib['user'] == user.username
+for contrib in contribs))
+self.assertIn('user', user.groups())
+self.assertIn('edit', user.rights())
 
 def test_registered_user_without_timestamp(self):
 """Test registered user when registration timestamp is None."""
@@ -69,6 +90,7 @@
 self.assertFalse(user.isEmailable())
 self.assertEqual(user.gender(), 'unknown')
 self.assertIn('invalid', user.getprops())
+self.assertFalse(user.is_thankable)
 
 def test_unregistered_user(self):
 """Test unregistered user."""

-- 
To view, visit https://gerrit.wikimedia.org/r/401408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I998822b88794a4e50783bc636729f0d23c88025c
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Framawiki 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [TEST] Add tests for User class

2018-01-01 Thread Framawiki (Code Review) 
Framawiki has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401408 )

Change subject: [TEST] Add tests for User class
..

[TEST] Add tests for User class

Bug: T60941
Change-Id: I998822b88794a4e50783bc636729f0d23c88025c
---
M tests/user_tests.py
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/08/401408/1

diff --git a/tests/user_tests.py b/tests/user_tests.py
index e8678f6..ac313a4 100644
--- a/tests/user_tests.py
+++ b/tests/user_tests.py
@@ -36,6 +36,26 @@
 self.assertTrue(user.isEmailable())
 self.assertEqual(user.gender(), 'unknown')
 self.assertIn('userid', user.getprops())
+self.assertEqual(user.getprops()['userid'], 287832)
+self.assertEqual(user.pageid, 6927779)
+self.assertEqual(user.getUserPage(),
+ pywikibot.Page(self.site, 'Benutzer:Xqt'))
+self.assertEqual(user.getUserPage(subpage='pwb'),
+ pywikibot.Page(self.site, 'Benutzer:Xqt/pwb'))
+self.assertEqual(user.getUserTalkPage(),
+ pywikibot.Page(self.site, 'Benutzer Diskussion:Xqt'))
+self.assertEqual(user.getUserTalkPage(subpage='pwb'),
+ pywikibot.Page(self.site,
+'Benutzer Diskussion:Xqt/pwb'))
+self.assertTrue(user.is_thankable)
+contribs = user.contributions(total=10)
+self.assertEqual(len(list(contribs)), 10)
+self.assertTrue(all(isinstance(contrib, tuple)
+for contrib in contribs))
+self.assertTrue(all('user' in contrib and contrib['user'] == 
user.username
+for contrib in contribs))
+self.assertIn('user', user.groups())
+self.assertIn('edit', user.rights())
 
 def test_registered_user_without_timestamp(self):
 """Test registered user when registration timestamp is None."""
@@ -69,6 +89,7 @@
 self.assertFalse(user.isEmailable())
 self.assertEqual(user.gender(), 'unknown')
 self.assertIn('invalid', user.getprops())
+self.assertFalse(user.is_thankable)
 
 def test_unregistered_user(self):
 """Test unregistered user."""

-- 
To view, visit https://gerrit.wikimedia.org/r/401408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I998822b88794a4e50783bc636729f0d23c88025c
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Framawiki 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits