[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] weblinkchecker.py: Use https for web.archive.org

[Zoranzoki21 (Code Review)]

Zoranzoki21 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/380923 )

Change subject: [bugfix] weblinkchecker.py: Use https for web.archive.org
..

[bugfix] weblinkchecker.py: Use https for web.archive.org

Changed from http on https for web.archive.org

Change-Id: Ifbb364bc01c33ca1661ee2c21cd1f2af953af390
---
M scripts/weblinkchecker.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/23/380923/2

diff --git a/scripts/weblinkchecker.py b/scripts/weblinkchecker.py
index c17a41e..5cdfcdb 100755
--- a/scripts/weblinkchecker.py
+++ b/scripts/weblinkchecker.py
@@ -226,7 +226,7 @@
 try:
 archive = _get_closest_memento_url(
 url,
-timegate_uri='http://web.archive.org/web/')
+timegate_uri='https://web.archive.org/web/')
 except Exception:
 archive = _get_closest_memento_url(
 url,

-- 
To view, visit https://gerrit.wikimedia.org/r/380923
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbb364bc01c33ca1661ee2c21cd1f2af953af390
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Zoranzoki21 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] weblinkchecker.py: Use https for web.archive.org

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/358053 )

Change subject: [bugfix] weblinkchecker.py: Use https for web.archive.org
..


[bugfix] weblinkchecker.py: Use https for web.archive.org

It's a temporary patch until the bug waiting for this bug to be fixed by 
memento_client library

Bug: T167463
Change-Id: I26cfebe7c1a09a93dfe4be659226ecb08f9315d5
---
M scripts/weblinkchecker.py
1 file changed, 7 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Xqt: Looks good to me, approved



diff --git a/scripts/weblinkchecker.py b/scripts/weblinkchecker.py
index c1618a5..61cc065 100755
--- a/scripts/weblinkchecker.py
+++ b/scripts/weblinkchecker.py
@@ -221,14 +221,19 @@
 def get_archive_url(url):
 """Get archive URL."""
 try:
-return _get_closest_memento_url(
+archive = _get_closest_memento_url(
 url,
 timegate_uri='http://web.archive.org/web/')
 except Exception:
-return _get_closest_memento_url(
+archive = _get_closest_memento_url(
 url,
 timegate_uri='http://timetravel.mementoweb.org/webcite/timegate/')
 
+# FIXME: Hack for T167463: Use https instead of http for archive.org links
+if archive.startswith('http://web.archive.org'):
+archive = archive.replace('http://', 'https://', 1)
+return archive
+
 
 def weblinksIn(text, withoutBracketed=False, onlyBracketed=False):
 """

-- 
To view, visit https://gerrit.wikimedia.org/r/358053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26cfebe7c1a09a93dfe4be659226ecb08f9315d5
Gerrit-PatchSet: 7
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Framawiki 
Gerrit-Reviewer: Framawiki 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Magul 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] weblinkchecker.py: Use https for web.archive.org

[Framawiki (Code Review)]

Framawiki has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358053 )

Change subject: [bugfix] weblinkchecker.py: Use https for web.archive.org
..

[bugfix] weblinkchecker.py: Use https for web.archive.org

It's a temporary patch until the bug waiting for this bug to be fixed by 
memento_client library

Bug: T167463
Change-Id: I26cfebe7c1a09a93dfe4be659226ecb08f9315d5
---
M scripts/weblinkchecker.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/53/358053/1

diff --git a/scripts/weblinkchecker.py b/scripts/weblinkchecker.py
index c1618a5..34b563d 100755
--- a/scripts/weblinkchecker.py
+++ b/scripts/weblinkchecker.py
@@ -221,13 +221,17 @@
 def get_archive_url(url):
 """Get archive URL."""
 try:
-return _get_closest_memento_url(
+archive = _get_closest_memento_url(
 url,
 timegate_uri='http://web.archive.org/web/')
 except Exception:
-return _get_closest_memento_url(
+archive = _get_closest_memento_url(
 url,
 timegate_uri='http://timetravel.mementoweb.org/webcite/timegate/')
+# FIXME: Hack for T167463: Use https instead of http for archive.org links
+if archive[:22] == 'http://web.archive.org':
+archive = 'https://web.archive.org' + archive[22:]
+return archive
 
 
 def weblinksIn(text, withoutBracketed=False, onlyBracketed=False):

-- 
To view, visit https://gerrit.wikimedia.org/r/358053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I26cfebe7c1a09a93dfe4be659226ecb08f9315d5
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Framawiki 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits