[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-29 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400991 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I9e8135cf31007e7108e7b320dd047d908d08665c
---
M tests/daemonize_tests.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/91/400991/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index d997ff4..69c821e 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -4,6 +4,7 @@
 from __future__ import absolute_import, unicode_literals
 
 import os
+
 import unitest
 
 from pywikibot import daemonize

-- 
To view, visit https://gerrit.wikimedia.org/r/400991
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e8135cf31007e7108e7b320dd047d908d08665c
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-29 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400956 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: Id8b164a8c007a421c303b288e0009e553ae29f56
---
M tests/daemonize_tests.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/56/400956/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index 59586f6..d997ff4 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -43,6 +43,6 @@
 
 if __name__ == '__main__':  # pragma: no cover
 try:
-unittest.main()
+unitest.main()
 except SystemExit:
 pass

-- 
To view, visit https://gerrit.wikimedia.org/r/400956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8b164a8c007a421c303b288e0009e553ae29f56
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-29 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400943 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I79fa4946d01f629efb9cad801ec54bf3b6ee95cf
---
M tests/daemonize_tests.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/43/400943/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index 07c9790..59586f6 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -4,6 +4,7 @@
 from __future__ import absolute_import, unicode_literals
 
 import os
+import unitest
 
 from pywikibot import daemonize
 

-- 
To view, visit https://gerrit.wikimedia.org/r/400943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79fa4946d01f629efb9cad801ec54bf3b6ee95cf
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-29 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400926 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I27bd7237182e92f88df95fc9f9735a1da8f6585f
---
M tests/daemonize_tests.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/26/400926/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index dee9435..07c9790 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -37,11 +37,11 @@
 
 def test_daemonize_writepid_True():
 os.fork()
-#cannot be tested because spaghetti code
+# cannot be tested because spaghetti code
 
 
 if __name__ == '__main__':  # pragma: no cover
 try:
 unittest.main()
 except SystemExit:
-pass
+pass

-- 
To view, visit https://gerrit.wikimedia.org/r/400926
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27bd7237182e92f88df95fc9f9735a1da8f6585f
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-29 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400905 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I33fe6d83014590b701dfdb999fedb1b73a127e69
---
M tests/daemonize_tests.py
1 file changed, 9 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/05/400905/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index f76e569..dee9435 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -1,15 +1,15 @@
 # -*- coding: utf-8 -*-
 """Tests for BasePage subclasses."""
-#
 
 from __future__ import absolute_import, unicode_literals
 
-from pywikibot import daemonize
-
 import os
+
+from pywikibot import daemonize
 
 
 def test_daemonize_os_exit():
+os.fork()
 os.fork()
 daemonize.daemonize()
 daemonize.daemonize()
@@ -37,14 +37,11 @@
 
 def test_daemonize_writepid_True():
 os.fork()
-# cannot be tested because spaghetti code
+#cannot be tested because spaghetti code
 
 
-def load_tests(loader, tests, pattern):
-test_daemonize_os_exit()
-test_daemonize_closedstream_true()
-test_daemonize_closedstream_false()
-test_daemonize_changedirectory_true()
-test_daemonize_changeddirectory_false()
-test_daemonize_writepid_True()
-test_redirectstd_true()
+if __name__ == '__main__':  # pragma: no cover
+try:
+unittest.main()
+except SystemExit:
+pass

-- 
To view, visit https://gerrit.wikimedia.org/r/400905
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33fe6d83014590b701dfdb999fedb1b73a127e69
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400624 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: If29aed0d8c8103d811a89c2dabda3f5f58833192
---
M tests/daemonize_tests.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/24/400624/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index e2bc459..f76e569 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
-"""Test for daemonize"""
+"""Tests for BasePage subclasses."""
+#
 
 from __future__ import absolute_import, unicode_literals
 

-- 
To view, visit https://gerrit.wikimedia.org/r/400624
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If29aed0d8c8103d811a89c2dabda3f5f58833192
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400621 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I76893da106d981fe87c6610cf69f8d3173ec3fc3
---
M tests/daemonize_tests.py
1 file changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/21/400621/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index 5cdb882..e2bc459 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -1,9 +1,5 @@
 # -*- coding: utf-8 -*-
-"""Test for daemonize
-
-Description
-
-"""
+"""Test for daemonize"""
 
 from __future__ import absolute_import, unicode_literals
 

-- 
To view, visit https://gerrit.wikimedia.org/r/400621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76893da106d981fe87c6610cf69f8d3173ec3fc3
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400620 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I33f7d7bc1f794c83f07dacd93ce5abe4a124bf15
---
M tests/daemonize_tests.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/20/400620/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index 50a1a25..5cdb882 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -1,7 +1,8 @@
 # -*- coding: utf-8 -*-
+"""Test for daemonize
 
-"""
-Test for daemonize
+Description
+
 """
 
 from __future__ import absolute_import, unicode_literals

-- 
To view, visit https://gerrit.wikimedia.org/r/400620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33f7d7bc1f794c83f07dacd93ce5abe4a124bf15
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400599 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: Idc867df606a8cfa2d392d41b67710bed2f3570b5
---
M tests/daemonize_tests.py
1 file changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/99/400599/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index baf2506..50a1a25 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -1,29 +1,47 @@
 # -*- coding: utf-8 -*-
 
+"""
+Test for daemonize
+"""
+
 from __future__ import absolute_import, unicode_literals
 
 from pywikibot import daemonize
 
 import os
 
+
 def test_daemonize_os_exit():
 os.fork()
 daemonize.daemonize()
 daemonize.daemonize()
+
+
 def test_daemonize_closedstream_true():
 daemonize.daemonize(True, True, False, None)
+
+
 def test_daemonize_closedstream_false():
 daemonize.daemonize(False, True, False, None)
+
+
 def test_daemonize_changedirectory_true():
 daemonize.daemonize(True, True, False, None)
+
+
 def test_daemonize_changeddirectory_false():
 daemonize.daemonize(True, False, False, None)
+
+
 def test_redirectstd_true():
 daemonize.daemonize(True, True, False, 'Test')
+
+
 def test_daemonize_writepid_True():
 os.fork()
 # cannot be tested because spaghetti code
 
+
 def load_tests(loader, tests, pattern):
 test_daemonize_os_exit()
 test_daemonize_closedstream_true()

-- 
To view, visit https://gerrit.wikimedia.org/r/400599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc867df606a8cfa2d392d41b67710bed2f3570b5
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400597 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: Icc6e72f8067c4da5e07abaf76b0e3d23859a6a6b
---
M tests/daemonize_tests.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/97/400597/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index a954456..baf2506 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-from __future__ import absolute_import, unicode_literals, docstring
+from __future__ import absolute_import, unicode_literals
 
 from pywikibot import daemonize
 

-- 
To view, visit https://gerrit.wikimedia.org/r/400597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc6e72f8067c4da5e07abaf76b0e3d23859a6a6b
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400596 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I21adc517a98b8c966bd39a915fd5896b1db4b694
---
M tests/daemonize_tests.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/96/400596/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index 9254187..a954456 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -1,3 +1,5 @@
+# -*- coding: utf-8 -*-
+
 from __future__ import absolute_import, unicode_literals, docstring
 
 from pywikibot import daemonize

-- 
To view, visit https://gerrit.wikimedia.org/r/400596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21adc517a98b8c966bd39a915fd5896b1db4b694
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400595 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I1099f775a0f51bbfebb4349239ea8447d0b61b81
---
M tests/daemonize_tests.py
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/95/400595/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index a9a60e1..9254187 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -1,4 +1,4 @@
-from __future__ import absolute_import, unicode_literals
+from __future__ import absolute_import, unicode_literals, docstring
 
 from pywikibot import daemonize
 
@@ -10,21 +10,17 @@
 daemonize.daemonize()
 def test_daemonize_closedstream_true():
 daemonize.daemonize(True, True, False, None)
-
 def test_daemonize_closedstream_false():
 daemonize.daemonize(False, True, False, None)
-
 def test_daemonize_changedirectory_true():
 daemonize.daemonize(True, True, False, None)
-
 def test_daemonize_changeddirectory_false():
 daemonize.daemonize(True, False, False, None)
-
 def test_redirectstd_true():
 daemonize.daemonize(True, True, False, 'Test')
 def test_daemonize_writepid_True():
 os.fork()
-#cannot be tested because spaghetti code
+# cannot be tested because spaghetti code
 
 def load_tests(loader, tests, pattern):
 test_daemonize_os_exit()

-- 
To view, visit https://gerrit.wikimedia.org/r/400595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1099f775a0f51bbfebb4349239ea8447d0b61b81
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400594 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I1ba1dd5a814054b2da9ef5d3d997f710f42d85bf
---
M tests/daemonize_tests.py
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/94/400594/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index 3d4deff..a9a60e1 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -1,4 +1,7 @@
+from __future__ import absolute_import, unicode_literals
+
 from pywikibot import daemonize
+
 import os
 
 def test_daemonize_os_exit():

-- 
To view, visit https://gerrit.wikimedia.org/r/400594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ba1dd5a814054b2da9ef5d3d997f710f42d85bf
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400593 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: Ied5109832bf4523bec95bab9e6c89a632169fa5f
---
M tests/daemonize_tests.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/93/400593/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index 8cf90a9..3d4deff 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -14,7 +14,7 @@
 def test_daemonize_changedirectory_true():
 daemonize.daemonize(True, True, False, None)
 
-def test_daemonize_changeddirectory_false(): 
+def test_daemonize_changeddirectory_false():
 daemonize.daemonize(True, False, False, None)
 
 def test_redirectstd_true():

-- 
To view, visit https://gerrit.wikimedia.org/r/400593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied5109832bf4523bec95bab9e6c89a632169fa5f
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-28 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400592 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I3fb8d7d9963c0ff034c3d3aa3c19161d0b2b9030
---
M tests/daemonize_tests.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/92/400592/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index a4fb615..8cf90a9 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -18,12 +18,12 @@
 daemonize.daemonize(True, False, False, None)
 
 def test_redirectstd_true():
-daemonize.daemonize(True, True, False, "Test")
+daemonize.daemonize(True, True, False, 'Test')
 def test_daemonize_writepid_True():
 os.fork()
 #cannot be tested because spaghetti code
 
-def load_tests(loader, tests, pattern): 
+def load_tests(loader, tests, pattern):
 test_daemonize_os_exit()
 test_daemonize_closedstream_true()
 test_daemonize_closedstream_false()

-- 
To view, visit https://gerrit.wikimedia.org/r/400592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fb8d7d9963c0ff034c3d3aa3c19161d0b2b9030
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Creating daemonize_tests.py

2017-12-27 Thread Eisenhaus335 (Code Review) 
Eisenhaus335 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/400465 )

Change subject: Creating daemonize_tests.py
..

Creating daemonize_tests.py

Change-Id: I1b57963c65d69d7ea5fbe9651e5c45c7ea4f0261
---
M tests/daemonize_tests.py
1 file changed, 14 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/65/400465/1

diff --git a/tests/daemonize_tests.py b/tests/daemonize_tests.py
index 051d8ea..a83491f 100644
--- a/tests/daemonize_tests.py
+++ b/tests/daemonize_tests.py
@@ -2,25 +2,24 @@
 from pywikibot import daemonize
 import os
 
-class TestCase1:
-   def test_daemonize_os_exit():
-  os.fork()
-  daemonize.daemonize()
-   def test_daemonize_closedstream_true():
-  daemonize.daemonize(True, True, False, None)
+def test_daemonize_os_exit():
+   os.fork()
+   daemonize.daemonize()
+def test_daemonize_closedstream_true():
+   daemonize.daemonize(True, True, False, None)
 
-   def test_daemonize_closedstream_false():
-  daemonize.daemonize(False, True, False, None)
+def test_daemonize_closedstream_false():
+   daemonize.daemonize(False, True, False, None)
 
-   def test_daemonize_changedirectory_true():
-  daemonize.daemonize(True, True, False, None)
+def test_daemonize_changedirectory_true():
+   daemonize.daemonize(True, True, False, None)
 
-   def test_daemonize_changeddirectory_false():
-  daemonize.daemonize(True, False, False, None)
+def test_daemonize_changeddirectory_false():
+   daemonize.daemonize(True, False, False, None)
 
-   def test_daemonize_writepid_True():
-  os.fork()
-  """cannot be tested because spaghetti code"""
+def test_daemonize_writepid_True():
+   os.fork()
+   """cannot be tested because spaghetti code"""
 
 def load_tests(loader, tests, pattern):
test_daemonize_os_exit()

-- 
To view, visit https://gerrit.wikimedia.org/r/400465
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b57963c65d69d7ea5fbe9651e5c45c7ea4f0261
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Eisenhaus335 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits