Rafidaslam has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402591 )
Change subject: imagecopy: Convert to use requests
......................................................................
imagecopy: Convert to use requests
Convert scripts/imagecopy.py to use `requests`
instead of `urllib`.
Also removes `url` parameter from `pageTextPost()`
since it's not used anywhere in the function.
Bug: T130523
Change-Id: I278081b24ff265a43c37372cd26f6fbae1c3b44e
---
M scripts/imagecopy.py
1 file changed, 7 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/91/402591/1
diff --git a/scripts/imagecopy.py b/scripts/imagecopy.py
index 377f3c6..02134a5 100644
--- a/scripts/imagecopy.py
+++ b/scripts/imagecopy.py
@@ -65,6 +65,7 @@
import socket
import threading
import webbrowser
+import requests
import pywikibot
@@ -77,13 +78,8 @@
if not PY2:
import tkinter as Tkinter
-
- from urllib.parse import urlencode
- from urllib.request import urlopen
else:
import Tkinter
-
- from urllib import urlencode, urlopen
try:
from pywikibot.userinterfaces.gui import Tkdialog
@@ -203,14 +199,15 @@
}
-def pageTextPost(url, parameters):
+def pageTextPost(parameters):
"""Get data from commons helper page."""
gotInfo = False
while not gotInfo:
try:
- commonsHelperPage = urlopen(
- "http://tools.wmflabs.org/commonshelper/index.php";, parameters)
- data = commonsHelperPage.read().decode('utf-8')
+ commonsHelperPage = requests.post(
+ "https://tools.wmflabs.org/commonshelper/index.php";,
+ data=parameters)
+ data = commonsHelperPage.content.decode('utf-8')
gotInfo = True
except IOError:
pywikibot.output(u'Got an IOError, let\'s try again')
@@ -246,10 +243,8 @@
'doit': 'Uitvoeren'
}
- tosend = urlencode(tosend)
pywikibot.output(tosend)
- CH = pageTextPost('http://tools.wmflabs.org/commonshelper/index.php',
- tosend)
+ CH = pageTextPost(tosend)
pywikibot.output('Got CH desc.')
tablock = CH.split('<textarea ')[1].split('>')[0]
--
To view, visit https://gerrit.wikimedia.org/r/402591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I278081b24ff265a43c37372cd26f6fbae1c3b44e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Rafidaslam <rafidt...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
