[MediaWiki-commits] [Gerrit] pywikibot...FLOSSbot[master]: repository: fix error verbosity

2016-09-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: repository: fix error verbosity
..


repository: fix error verbosity

Change-Id: I95656a1b550d21537b3a178eeb55eb54fc14f50e
Signed-off-by: Loic Dachary 
---
M FLOSSbot/repository.py
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Dachary: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/FLOSSbot/repository.py b/FLOSSbot/repository.py
index f89b65c..e43b614 100644
--- a/FLOSSbot/repository.py
+++ b/FLOSSbot/repository.py
@@ -199,12 +199,14 @@
 } ORDER BY ?item
 """
 query = query + " # " + str(time.time())
+log.debug(query)
 site = pywikibot.Site(self.args.language_code, "wikidata")
 self.setup_cache(site)
 for item in pg.WikidataSPARQLPageGenerator(query,
site=site,
result_type=list):
-log.info("WORKING ON https://www.wikidata.org/wiki/; + item.id)
+log.info("WORKING ON https://www.wikidata.org/wiki/; +
+ item.getID())
 self.fixup_protocol(site, item)
 self.fixup_rank(site, item)
 
@@ -274,7 +276,7 @@
 continue
 target_protocol = Repository.guess_protocol(claim)
 if not target_protocol:
-log.error("ERROR " + claim.getTarget())
+log.error(claim.getTarget())
 continue
 protocol = pywikibot.Claim(site, P_protocol, 0)
 protocol.setTarget(target_protocol)
@@ -416,8 +418,7 @@
 protocol = Repository.guess_protocol_from_url(url)
 if protocol:
 if not Repository.verify_protocol(url, protocol, credentials):
-log.error("ERROR " + url +
-  " does not obey the expected protocol " +
+log.error(url + " does not obey the expected protocol " +
   str(protocol))
 return None
 else:

-- 
To view, visit https://gerrit.wikimedia.org/r/310690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95656a1b550d21537b3a178eeb55eb54fc14f50e
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/bots/FLOSSbot
Gerrit-Branch: master
Gerrit-Owner: Dachary 
Gerrit-Reviewer: Dachary 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot...FLOSSbot[master]: repository: fix error verbosity

2016-09-14 Thread Dachary (Code Review) 
Dachary has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/310690

Change subject: repository: fix error verbosity
..

repository: fix error verbosity

Change-Id: I95656a1b550d21537b3a178eeb55eb54fc14f50e
Signed-off-by: Loic Dachary 
---
M FLOSSbot/repository.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/bots/FLOSSbot 
refs/changes/90/310690/1

diff --git a/FLOSSbot/repository.py b/FLOSSbot/repository.py
index f89b65c..4ef8b5f 100644
--- a/FLOSSbot/repository.py
+++ b/FLOSSbot/repository.py
@@ -199,12 +199,13 @@
 } ORDER BY ?item
 """
 query = query + " # " + str(time.time())
+log.debug(query)
 site = pywikibot.Site(self.args.language_code, "wikidata")
 self.setup_cache(site)
 for item in pg.WikidataSPARQLPageGenerator(query,
site=site,
result_type=list):
-log.info("WORKING ON https://www.wikidata.org/wiki/; + item.id)
+log.info("WORKING ON https://www.wikidata.org/wiki/; + 
item.getID())
 self.fixup_protocol(site, item)
 self.fixup_rank(site, item)
 
@@ -274,7 +275,7 @@
 continue
 target_protocol = Repository.guess_protocol(claim)
 if not target_protocol:
-log.error("ERROR " + claim.getTarget())
+log.error(claim.getTarget())
 continue
 protocol = pywikibot.Claim(site, P_protocol, 0)
 protocol.setTarget(target_protocol)
@@ -416,8 +417,7 @@
 protocol = Repository.guess_protocol_from_url(url)
 if protocol:
 if not Repository.verify_protocol(url, protocol, credentials):
-log.error("ERROR " + url +
-  " does not obey the expected protocol " +
+log.error(url + " does not obey the expected protocol " +
   str(protocol))
 return None
 else:

-- 
To view, visit https://gerrit.wikimedia.org/r/310690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95656a1b550d21537b3a178eeb55eb54fc14f50e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/bots/FLOSSbot
Gerrit-Branch: master
Gerrit-Owner: Dachary 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits