[MediaWiki-commits] [Gerrit] regex() must be a classmethod - change (thumbor/purger)

[Gilles (Code Review)]

Gilles has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/252460

Change subject: regex() must be a classmethod
..

regex() must be a classmethod

Because the instance isn't created directly in __init.py__, so only
the class is available then.

Change-Id: I46e16091c760da052e0948ba4953831604da2461
---
M tc_purger/handlers/purger.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/thumbor/purger 
refs/changes/60/252460/1

diff --git a/tc_purger/handlers/purger.py b/tc_purger/handlers/purger.py
index 726b160..106215e 100644
--- a/tc_purger/handlers/purger.py
+++ b/tc_purger/handlers/purger.py
@@ -12,7 +12,8 @@
 
 
 class UrlPurgerHandler(ImagingHandler):
-def regex(self):
+@classmethod
+def regex(cls):
 '''
 :return: The regex used for routing.
 :rtype: string

-- 
To view, visit https://gerrit.wikimedia.org/r/252460
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46e16091c760da052e0948ba4953831604da2461
Gerrit-PatchSet: 1
Gerrit-Project: thumbor/purger
Gerrit-Branch: master
Gerrit-Owner: Gilles 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] regex() must be a classmethod - change (thumbor/purger)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: regex() must be a classmethod
..


regex() must be a classmethod

Because the instance isn't created directly in __init.py__, so only
the class is available then.

Change-Id: I46e16091c760da052e0948ba4953831604da2461
---
M tc_purger/handlers/purger.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Gilles: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tc_purger/handlers/purger.py b/tc_purger/handlers/purger.py
index 726b160..106215e 100644
--- a/tc_purger/handlers/purger.py
+++ b/tc_purger/handlers/purger.py
@@ -12,7 +12,8 @@
 
 
 class UrlPurgerHandler(ImagingHandler):
-def regex(self):
+@classmethod
+def regex(cls):
 '''
 :return: The regex used for routing.
 :rtype: string

-- 
To view, visit https://gerrit.wikimedia.org/r/252460
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I46e16091c760da052e0948ba4953831604da2461
Gerrit-PatchSet: 1
Gerrit-Project: thumbor/purger
Gerrit-Branch: master
Gerrit-Owner: Gilles 
Gerrit-Reviewer: Gilles 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits